bpo-36346: Make using the legacy Unicode C API optional #21437
Merged
+360
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two compile time options: HAVE_UNICODE_WCHAR_CACHE and USE_UNICODE_WCHAR_CACHE. USE_UNICODE_WCHAR_CACHE makes the interpreter not using the wchar_t cache and the legacy Unicode C API. HAVE_UNICODE_WCHAR_CACHE removes the wchar_t cache and the legacy Unicode C API that depends on it.
serhiy-storchaka
requested review from
a team,
rhettinger and
skrah
as code owners
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 20, 2020
Add compile time option USE_UNICODE_WCHAR_CACHE. Setting it to 0 makes the interpreter not using the wchar_t cache and the legacy Unicode C API.
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Add compile time option USE_UNICODE_WCHAR_CACHE. Setting it to 0 makes the interpreter not using the wchar_t cache and the legacy Unicode C API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use the legacy Unicode C API which depends on the wchar_t* cache if USE_UNICODE_WCHAR_CACHE is defined as false.
It can help to test in advance the effect of removing the wchar_t* cache.
https://bugs.python.org/issue36346