Skip to content

Fix broken circular dep error #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

Fix broken circular dep error #2320

merged 2 commits into from
Jun 6, 2025

Conversation

jerryzh168
Copy link
Contributor

Summary: buck test 'fbcode//mode/opt' fbcode//apf/utils/fp8_compute/tests:fp8_compute_utils_test -- --exact 'apf/utils/fp8_compute/tests:fp8_compute_utils_test - apf.utils.fp8_compute.tests.fp8_compute_utils_test.FP8ComputeUtilsTest: test_apply_fp8_linear_compute_regex_match_parent'

Reviewed By: jerryzh168, jarodhou

Differential Revision: D75980282
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 5, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2320

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Merge Blocking SEVs

There is 1 active merge blocking SEVs. Please view them below:

If you must merge, use @pytorchbot merge -f.

✅ No Failures

As of commit 258c7b6 with merge base 0d9631b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75980282
@drisspg drisspg self-requested a review June 5, 2025 18:36
@jerryzh168 jerryzh168 added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jun 5, 2025
@drisspg @facebook-github-bot
Fix broken circular dep error (pytorch#2320)
6e824c9 
Summary:
Pull Request resolved: pytorch#2320

 buck test 'fbcode//mode/opt' fbcode//apf/utils/fp8_compute/tests:fp8_compute_utils_test -- --exact 'apf/utils/fp8_compute/tests:fp8_compute_utils_test - apf.utils.fp8_compute.tests.fp8_compute_utils_test.FP8ComputeUtilsTest: test_apply_fp8_linear_compute_regex_match_parent'

Reviewed By: amrshennawi, jerryzh168, jarodhou

Differential Revision: D75980282
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75980282
@facebook-github-bot
Copy link
Contributor

@jerryzh168 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@facebook-github-bot
Copy link
Contributor

@jerryzh168 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@facebook-github-bot facebook-github-bot merged commit d6cfdad into pytorch:main Jun 6, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing Use this tag if you don't want this PR to show up in release notes
3 participants
@jerryzh168 @facebook-github-bot @drisspg