Skip to content

Supress some lookup errors if a module contains compile_error! #149484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Supress some lookup errors if a module contains compile_error! #149484

wants to merge 1 commit into from
+66 −1

Conversation

@ogoffart
Copy link
Contributor

@ogoffart ogoffart commented Nov 30, 2025 •
edited by rustbot
Loading

The problem is that when a macro expand to compile_error! because its input is malformed, the actual error message from the compile_error! might be hidden in a long list of other messages about using items that should have otherwise been generated by the macro.

So suppress error about missing items in that module.

Fixes #68838
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 30, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ogoffart
Supress some lookup errors if a module contains compile_error!
87af5f5 
The problem is that when a macro expand to `compile_error!` because
its input is malformed, the actual error message from the
`compile_error!` might be hidden in a long list of other messages about
using items that should have otherwise been generated by the macro.

So suppress error about missing items in that module.
@lcnr
Copy link
Contributor

lcnr commented Dec 1, 2025

@rustbot reroll
@rustbot rustbot assigned fee1-dead and unassigned lcnr Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

5 participants

@ogoffart @rustbot @rust-log-analyzer @lcnr @fee1-dead