Skip to content

Update the comment in the add_typo_suggestion function #149505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2025
Merged

Update the comment in the add_typo_suggestion function #149505

merged 1 commit into from
Dec 1, 2025
+1 −1

Conversation

@reddevilmidzy
Copy link
Contributor

@reddevilmidzy reddevilmidzy commented Dec 1, 2025

This comment was added to 089810a. However, the test for the comment was moved elsewhere in #145897.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 1, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2025

r? @WaffleLapkin

rustbot has assigned @WaffleLapkin.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@WaffleLapkin
Copy link
Member

WaffleLapkin commented Dec 1, 2025

What is the purpose of this? i.e. is it even important that the comment is traceable to the test? I feel like the diagnostic itself, not the file, is the important part here.
@reddevilmidzy
Copy link
Contributor Author

reddevilmidzy commented Dec 1, 2025

While reading the comments, I became curious about the exact circumstances under which this message was printed, so I looked for the file in question, but couldn't find it. So, I changed the comment to make it easier to find. If you deem it unnecessary, I'll close the PR.
@WaffleLapkin
Copy link
Member

WaffleLapkin commented Dec 1, 2025

@bors r+ rollup
@bors
Copy link
Collaborator

bors commented Dec 1, 2025

📌 Commit 31106eb has been approved by WaffleLapkin

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 1, 2025
Merged
bors added a commit that referenced this pull request Dec 1, 2025
@bors
Auto merge of #149515 - matthiaskrgr:rollup-djmciuc, r=matthiaskrgr
1d60f9e 
Rollup of 6 pull requests

Successful merges:

 - #149393 (expand valid edition range for use-path-segment-kw.rs)
 - #149427 (Make the capitalization explicit on keyword misspell error)
 - #149433 (Use a delayed bug for this layout ICE)
 - #149473 (Tidying up UI tests [7/N])
 - #149505 (Update the comment in the add_typo_suggestion function)
 - #149513 (`rust-analyzer` subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 453fca5 into rust-lang:main Dec 1, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Dec 1, 2025
rust-timer added a commit that referenced this pull request Dec 1, 2025
@rust-timer
Unrolled build for #149505
8c570e4 
Rollup merge of #149505 - reddevilmidzy:fix, r=WaffleLapkin

Update the comment in the add_typo_suggestion function

This comment was added to 089810a. However, the test for the comment was moved elsewhere in #145897.
@reddevilmidzy reddevilmidzy deleted the fix branch December 2, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

4 participants

@reddevilmidzy @rustbot @WaffleLapkin @bors