Cleanup compiler test. remove unnecessary isJavaAtLeast conditions
#24589
+9
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
reviewed
Nov 29, 2025
Member
hamzaremmal
left a comment
hamzaremmal
left a comment
There was a problem hiding this comment.
Hi @xuwei-k, thanks for taking care of this. I left a few comments for some improvements.
| null | ||
| } | ||
| try { | ||
| MethodHandles |
Member
There was a problem hiding this comment.
There is no need to go via MethodHandles anymore, we can call the method directly here.
|
|
||
| if scala.util.Properties.isJavaAtLeast("16") then | ||
| tests ::= compileFilesInDir("tests/pos-java16+", defaultOptions.and("-Wsafe-init")) | ||
| tests ::= compileFilesInDir("tests/pos-java16+", defaultOptions.and("-Wsafe-init")) |
Member
There was a problem hiding this comment.
Maybe it's worth moving all the tests to the tests/pos folder and delete the tests/pos-java16+ folder.
Contributor
There was a problem hiding this comment.
There is a test pseudo-directive // test: -jvm 11+ for limiting the jvm version as necessary.
Member
|
Also, I have a branch somewhere that I need to push that cleans up some of the properties we use for testing, like |
xuwei-k
force-pushed
the
compiler-test-isJavaAtLeast
branch
from
a02ffa4 to
a73b22e
Compare
xuwei-k
force-pushed
the
compiler-test-isJavaAtLeast
branch
from
a73b22e to
ce392ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.