Update mypy (#895)

* catalogs extension scratch

* import fixes

* pre-commit

* update mypy

* update changelog

* remove old code

* removals

* shorten line?

* lint

* fix invalid_intervals

* fix type

---------

Co-authored-by: vincentsarago <vincent.sarago@gmail.com>

Author: jonhealy1

.pre-commit-config.yaml

@@ -1,13 +1,13 @@
 repos:
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: "v0.2.2"
+    rev: "v0.15.8"
     hooks:
       - id: ruff
         args: [--fix, --exit-non-zero-on-fix]
       - id: ruff-format
 
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.19.0
+    rev: v1.20.0
     hooks:
     - id: mypy
       language_version: python

CHANGES.md

@@ -2,6 +2,10 @@
 
 ## [Unreleased]
 
+### Fixed
+
+- fix mypy type errors in transaction extension for Python 3.14 compatibility (mypy 1.20.0) ([#895](https://github.com/stac-utils/stac-fastapi/pull/895))
+
 ## [6.2.1] - 2026-02-10
 
 ### Fixed 

stac_fastapi/api/stac_fastapi/api/app.py

@@ -1,6 +1,5 @@
 """Fastapi app creation."""
 
-
 import inspect
 from typing import Awaitable, Callable, Dict, List, Optional, Tuple, Type, Union
 

stac_fastapi/api/tests/test_api.py

@@ -39,9 +39,9 @@ def _assert_dependency_applied(api, routes):
         with TestClient(api.app) as client:
             for route in routes:
                 response = getattr(client, route["method"].lower())(route["path"])
-                assert (
-                    response.status_code == 401
-                ), "Unauthenticated requests should be rejected"
+                assert response.status_code == 401, (
+                    "Unauthenticated requests should be rejected"
+                )
                 assert response.json() == {"detail": "Not authenticated"}
 
                 path = route["path"].format(
@@ -54,9 +54,9 @@ def _assert_dependency_applied(api, routes):
                     content=route["payload"],
                     headers={"content-type": "application/json"},
                 )
-                assert (
-                    200 <= response.status_code < 300
-                ), "Authenticated requests should be accepted"
+                assert 200 <= response.status_code < 300, (
+                    "Authenticated requests should be accepted"
+                )
                 assert response.json() == "dummy response"
 
     @staticmethod
@@ -72,9 +72,9 @@ def _assert_dependency_not_applied(api, routes):
                     content=route["payload"],
                     headers={"content-type": "application/json"},
                 )
-                assert (
-                    200 <= response.status_code < 300
-                ), "Authenticated requests should be accepted"
+                assert 200 <= response.status_code < 300, (
+                    "Authenticated requests should be accepted"
+                )
                 assert response.json() == "dummy response"
 
     def test_openapi_content_type(self):
@@ -400,23 +400,17 @@ def test_add_default_method_route_dependencies_after_building_api(
 
 
 class DummyCoreClient(core.BaseCoreClient):
-    def all_collections(self, *args, **kwargs):
-        ...
+    def all_collections(self, *args, **kwargs): ...
 
-    def get_collection(self, *args, **kwargs):
-        ...
+    def get_collection(self, *args, **kwargs): ...
 
-    def get_item(self, *args, **kwargs):
-        ...
+    def get_item(self, *args, **kwargs): ...
 
-    def get_search(self, *args, **kwargs):
-        ...
+    def get_search(self, *args, **kwargs): ...
 
-    def post_search(self, *args, **kwargs):
-        ...
+    def post_search(self, *args, **kwargs): ...
 
-    def item_collection(self, *args, **kwargs):
-        ...
+    def item_collection(self, *args, **kwargs): ...
 
 
 class DummyTransactionsClient(BaseTransactionsClient):

stac_fastapi/api/tests/test_app_prefix.py

@@ -12,8 +12,9 @@
 def get_link(landing_page, rel_type, method: Optional[str] = None):
     return next(
         filter(
-            lambda link: link["rel"] == rel_type
-            and (not method or link.get("method") == method),
+            lambda link: (
+                link["rel"] == rel_type and (not method or link.get("method") == method)
+            ),
             landing_page["links"],
         ),
         None,

stac_fastapi/extensions/stac_fastapi/extensions/core/aggregation/aggregation.py

@@ -1,4 +1,5 @@
 """Aggregation Extension."""
+
 from enum import Enum
 from typing import List, Type, Union
 

stac_fastapi/extensions/stac_fastapi/extensions/core/filter/filter.py

@@ -1,5 +1,6 @@
 # encoding: utf-8
 """Filter Extension."""
+
 from enum import Enum
 from typing import List, Type, Union
 

stac_fastapi/extensions/stac_fastapi/extensions/core/transaction/transaction.py

@@ -1,7 +1,7 @@
 """Transaction extension."""
 
 from enum import Enum
-from typing import List, Optional, Type, Union
+from typing import Any, Dict, List, Optional, Type, Union
 
 import attr
 from fastapi import APIRouter, Body, FastAPI
@@ -108,7 +108,10 @@ class PatchCollection(CollectionUri):
     ]
 }
 # ref: https://github.com/pydantic/pydantic/issues/889
-_patch_item_schema["items"]["anyOf"] = list(_patch_item_schema["$defs"].values())
+_patch_item_schema_dict: Dict[str, Any] = _patch_item_schema
+_patch_item_schema_dict["items"]["anyOf"] = list(
+    _patch_item_schema_dict["$defs"].values()
+)
 
 _patch_collection_schema = TypeAdapter(List[PatchOperation]).json_schema() | {
     "examples": [
@@ -146,8 +149,9 @@ class PatchCollection(CollectionUri):
     ]
 }
 # ref: https://github.com/pydantic/pydantic/issues/889
-_patch_collection_schema["items"]["anyOf"] = list(
-    _patch_collection_schema["$defs"].values()
+_patch_collection_schema_dict: Dict[str, Any] = _patch_collection_schema
+_patch_collection_schema_dict["items"]["anyOf"] = list(
+    _patch_collection_schema_dict["$defs"].values()
 )
 
 

stac_fastapi/extensions/tests/test_free_text.py

@@ -1,7 +1,6 @@
 # noqa: E501
 """test freetext extension."""
 
-
 from starlette.testclient import TestClient
 
 from stac_fastapi.api.app import StacApi

stac_fastapi/types/stac_fastapi/types/search.py

@@ -1,6 +1,5 @@
-"""stac_fastapi.types.search module.
+"""stac_fastapi.types.search module."""
 
-"""
 from datetime import datetime as dt
 from typing import Dict, List, Optional, Union, cast