confirm missing datetime when using pydantic serialization (#878)

* confirm missing datetime when using pydantic serialization

* update lock file

Author: vincentsarago

stac_fastapi/api/tests/conftest.py

@@ -53,6 +53,23 @@ def _item():
     )
 
 
+@pytest.fixture
+def _item_start_end():
+    return Item(
+        id="test_item_datetime",
+        type="Feature",
+        geometry={"type": "Point", "coordinates": [0, 0]},
+        bbox=[-180, -90, 180, 90],
+        properties={
+            "datetime": None,
+            "start_datetime": "2000-01-01T00:00:00Z",
+            "end_datetime": "2000-01-02T00:00:00Z",
+        },
+        links=item_links,
+        assets={},
+    )
+
+
 @pytest.fixture
 def item(_item: Item):
     return _item.model_dump_json()
@@ -119,6 +136,71 @@ def item_collection(
     return CoreClient
 
 
+@pytest.fixture
+def TestCoreClientDatetime(collection_dict, _item_start_end):
+    class CoreClient(core.BaseCoreClient):
+        def post_search(
+            self, search_request: BaseSearchPostRequest, **kwargs
+        ) -> stac.ItemCollection:
+            return stac.ItemCollection(
+                type="FeatureCollection",
+                features=[
+                    _item_start_end.model_dump(),
+                ],
+            )
+
+        def get_search(
+            self,
+            collections: Optional[List[str]] = None,
+            ids: Optional[List[str]] = None,
+            bbox: Optional[List[NumType]] = None,
+            intersects: Optional[str] = None,
+            datetime: Optional[Union[str, datetime]] = None,
+            limit: Optional[int] = 10,
+            **kwargs,
+        ) -> stac.ItemCollection:
+            return stac.ItemCollection(
+                type="FeatureCollection",
+                features=[
+                    _item_start_end.model_dump(),
+                ],
+            )
+
+        def get_item(self, item_id: str, collection_id: str, **kwargs) -> stac.Item:
+            return stac.Item(**_item_start_end.model_dump())
+
+        def all_collections(self, **kwargs) -> stac.Collections:
+            return stac.Collections(
+                collections=[stac.Collection(**collection_dict)],
+                links=[
+                    {"href": "test", "rel": "root"},
+                    {"href": "test", "rel": "self"},
+                    {"href": "test", "rel": "parent"},
+                ],
+            )
+
+        def get_collection(self, collection_id: str, **kwargs) -> stac.Collection:
+            return stac.Collection(**collection_dict)
+
+        def item_collection(
+            self,
+            collection_id: str,
+            bbox: Optional[List[Union[float, int]]] = None,
+            datetime: Optional[Union[str, datetime]] = None,
+            limit: int = 10,
+            token: str = None,
+            **kwargs,
+        ) -> stac.ItemCollection:
+            return stac.ItemCollection(
+                type="FeatureCollection",
+                features=[
+                    _item_start_end.model_dump(),
+                ],
+            )
+
+    return CoreClient
+
+
 @pytest.fixture
 def AsyncTestCoreClient(collection_dict, item_dict):
     class AsyncCoreClient(core.AsyncBaseCoreClient):

stac_fastapi/api/tests/test_app.py

@@ -610,3 +610,29 @@ async def async_health_check(request: Request):
                 "version": "0.1.0",
             },
         }
+
+
+def test_client_datetime(TestCoreClientDatetime):
+    """Check valid items with missing datetime."""
+
+    test_app = app.StacApi(
+        settings=ApiSettings(
+            enable_direct_response=False,
+            enable_response_models=False,
+        ),
+        client=TestCoreClientDatetime(),
+    )
+    with TestClient(test_app.app) as client:
+        item = client.get("/collections/test/items/test_item_datetime")
+        assert "datetime" in item.json()["properties"]
+
+    test_app = app.StacApi(
+        settings=ApiSettings(
+            enable_direct_response=False,
+            enable_response_models=True,
+        ),
+        client=TestCoreClientDatetime(),
+    )
+    with TestClient(test_app.app) as client:
+        item = client.get("/collections/test/items/test_item_datetime")
+        assert "datetime" in item.json()["properties"]