Skip to content

Conversation

@FrittenKeeZ
Copy link
Contributor

Issue is described here: statamic-rad-pack/mailchimp#137

It's not a breaking change, but is necessary for the above issue to be resolved - unless there's another mysterious way to hook into data to fix it?

@FrittenKeeZ
Copy link
Contributor Author

@jasonvarga it's been almost a year now - would you consider this for v6?

@jasonvarga jasonvarga merged commit 408767d into statamic:5.x Jan 21, 2026
26 checks passed
@micahhenshaw
Copy link
Contributor

@jasonvarga I think this might have broken using form field antlers in the form config. For example if i set {{ email }} in the reply to field of a form config, it gets dropped as it cant be parsed...

as a test, i added some logging to demonstrate:

array_walk_recursive($contents, function (&$value) use ($variables) {
    if (is_string($value)) {
        logger('parsing '.$value);
        $value = (string) Antlers::parse($value, $variables);
        logger('parsed to '.$value);
    }
});

which gives the following output:

[2026-01-22 00:50:03] local.DEBUG: parsing m7cn1era  
[2026-01-22 00:50:03] local.DEBUG: parsed to m7cn1era  

[2026-01-22 00:50:03] local.DEBUG: parsing {{ email }}  
[2026-01-22 00:50:03] local.DEBUG: parsed to   

[2026-01-22 00:50:03] local.DEBUG: parsing Website Enquiry  
[2026-01-22 00:50:03] local.DEBUG: parsed to Website Enquiry 

This was working before the change.

@jasonvarga
Copy link
Member

Reverted in 5.73.1.

@FrittenKeeZ Sorry about this. Happy to try this again with some more care around the bug this caused. And tests.

@FrittenKeeZ
Copy link
Contributor Author

FrittenKeeZ commented Jan 22, 2026

@jasonvarga It's quite alright, we've just never used the form variables in the configuration, so I never thought about that case. Seems like some general tests are missing for forms 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants