Skip to content

Commit 78e4337

Browse files
committed
[css-values-4] Incorporated feedback regarding value and phrasing
1 parent a6f80db commit 78e4337

File tree

4 files changed

+18
-17
lines changed

4 files changed

+18
-17
lines changed

‎css-grid-1/Overview.bs

+4-4
Original file line numberDiff line numberDiff line change
@@ -1511,7 +1511,7 @@ Explicit Track Sizing: the 'grid-template-rows' and 'grid-template-columns' prop
15111511
15121512
<dfn>&lt;track-size></dfn> = <<track-breadth>> | minmax( <<inflexible-breadth>> , <<track-breadth>> ) | fit-content( <<length-percentage [0,∞]>> )
15131513
<dfn>&lt;fixed-size></dfn> = <<fixed-breadth>> | minmax( <<fixed-breadth>> , <<track-breadth>> ) | minmax( <<inflexible-breadth>> , <<fixed-breadth>> )
1514-
<dfn>&lt;track-breadth></dfn> = <<length-percentage [0,∞]>> | <<fraction [0,∞]>> | min-content | max-content | auto
1514+
<dfn>&lt;track-breadth></dfn> = <<length-percentage [0,∞]>> | <<fraction>> | min-content | max-content | auto
15151515
<dfn>&lt;inflexible-breadth></dfn> = <<length-percentage [0,∞]>> | min-content | max-content | auto
15161516
<dfn>&lt;fixed-breadth></dfn> = <<length-percentage [0,∞]>>
15171517
<dfn>&lt;line-names></dfn> = '[' <<custom-ident>>* ']'
@@ -1540,7 +1540,7 @@ Track Sizes</h4>
15401540
and then resolve against that resulting <a>grid container</a> size
15411541
for the purpose of laying out the <a>grid</a> and its items.
15421542

1543-
<dt><dfn><<fraction [0,∞]>></dfn>
1543+
<dt><dfn><<fraction>></dfn>
15441544
<dd>
15451545
Specifies the track's <dfn dfn noexport>flex factor</dfn>.
15461546
Each <<fraction>>-sized track takes a share of the remaining space in proportion to its <a>flex factor</a>.
@@ -1873,7 +1873,7 @@ Flexible Tracks</h4>
18731873
which is then divided among the flex-sized rows and columns in proportion to their <a>flex factor</a>.
18741874

18751875
Each column or row's share of the <a>leftover space</a> can be computed as the column or row's
1876-
<code>&lt;flex> * &lt;leftover space> / &lt;sum of all <a>flex factors</a>&gt;</code>.
1876+
<code>&lt;fraction> * &lt;leftover space> / &lt;sum of all <a>flex factors</a>&gt;</code>.
18771877

18781878
When the available space is infinite
18791879
(which happens when the <a>grid container</a>’s width or height is <a>indefinite</a>),
@@ -4859,7 +4859,7 @@ Changes since the <a href="https://www.w3.org/TR/2020/CRD-css-grid-1-20201218/">
48594859
</blockquote>
48604860

48614861
<li id="change-2020-fr-unit">
4862-
Moved the definition of <<fraction>> to [[css-values-4#fractions]],
4862+
Renamed <<flex>> to <<fraction>> and moved its definition to [[css-values-4#fractions]],
48634863
as other specs also make use of it.
48644864
(<a href="https://github.com/w3c/csswg-drafts/issues/8027">Issue 8027</a>)
48654865
</ul>

‎css-grid-1/issues-cr-2016.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ <h1>CSS Grid Layout Level 1 Disposition of Comments for 2016-09-29 CR</h1>
292292
<span>Resolved: <a href='https://lists.w3.org/Archives/Public/www-style/2017Apr/0018.html'>https://lists.w3.org/Archives/Public/www-style/2017Apr/0018.html</a> <a href="https://www.w3.org/Mail/flatten/index?subject=https%3A%2F%2Flists.w3.org%2FArchives%2FPublic%2Fwww-style/2017Apr/0018.html"><abbr title="Thread">&#x2208;</abbr></a></span></pre>
293293
<pre class=' a' id='issue-32'>
294294
<span>Issue 32. <a href='#issue-32'>#</a></span>
295-
<span>Summary: Computed value for single value &lt;flex>?</span>
295+
<span>Summary: Computed value for single value &lt;fraction>?</span>
296296
<span>From: Mats Palmgren</span>
297297
<span>Comment: <a href='https://github.com/w3c/csswg-drafts/issues/529'>https://github.com/w3c/csswg-drafts/issues/529</a></span>
298298
<span>Response: <a href='https://github.com/w3c/csswg-drafts/issues/529#issuecomment-251841937'>https://github.com/w3c/csswg-drafts/issues/529#issuecomment-251841937</a></span>

‎css-grid-2/Overview.bs

+4-4
Original file line numberDiff line numberDiff line change
@@ -1595,7 +1595,7 @@ Explicit Track Sizing: the 'grid-template-rows' and 'grid-template-columns' prop
15951595
<dfn>&lt;line-name-list></dfn> = [ <<line-names>> | <<name-repeat>> ]+
15961596
<dfn>&lt;track-size></dfn> = <<track-breadth>> | minmax( <<inflexible-breadth>> , <<track-breadth>> ) | fit-content( <<length-percentage [0,∞]>> )
15971597
<dfn>&lt;fixed-size></dfn> = <<fixed-breadth>> | minmax( <<fixed-breadth>> , <<track-breadth>> ) | minmax( <<inflexible-breadth>> , <<fixed-breadth>> )
1598-
<dfn>&lt;track-breadth></dfn> = <<length-percentage [0,∞]>> | <<fraction [0,∞]>> | min-content | max-content | auto
1598+
<dfn>&lt;track-breadth></dfn> = <<length-percentage [0,∞]>> | <<fraction>> | min-content | max-content | auto
15991599
<dfn>&lt;inflexible-breadth></dfn> = <<length-percentage [0,∞]>> | min-content | max-content | auto
16001600
<dfn>&lt;fixed-breadth></dfn> = <<length-percentage [0,∞]>>
16011601
<dfn>&lt;line-names></dfn> = '[' <<custom-ident>>* ']'
@@ -1624,7 +1624,7 @@ Track Sizes</h4>
16241624
and then resolve against that resulting <a>grid container</a> size
16251625
for the purpose of laying out the <a>grid</a> and its items.
16261626

1627-
<dt><dfn><<fraction [0,∞]>></dfn>
1627+
<dt><dfn><<fraction>></dfn>
16281628
<dd>
16291629
A non-negative dimension with the unit ''fr'' specifying the track's <dfn dfn noexport>flex factor</dfn>.
16301630
Each <<fraction>>-sized track takes a share of the remaining space in proportion to its <a>flex factor</a>.
@@ -1963,7 +1963,7 @@ Flexible Tracks</h4>
19631963
which is then divided among the flex-sized rows and columns in proportion to their <a>flex factor</a>.
19641964

19651965
Each column or row's share of the <a>leftover space</a> can be computed as the column or row's
1966-
<code>&lt;flex> * &lt;leftover space> / &lt;sum of all <a>flex factors</a>&gt;</code>.
1966+
<code>&lt;fraction> * &lt;leftover space> / &lt;sum of all <a>flex factors</a>&gt;</code>.
19671967

19681968
When the available space is infinite
19691969
(which happens when the <a>grid container</a>’s width or height is <a>indefinite</a>),
@@ -5461,7 +5461,7 @@ Changes since the <a href="https://www.w3.org/TR/2020/CRD-css-grid-2-20201218/">
54615461
</blockquote>
54625462

54635463
<li id="change-2020-fr-unit">
5464-
Moved the definition of <<fraction>> to [[css-values-4#fractions]],
5464+
Renamed <<flex>> to <<fraction>> and moved its definition to [[css-values-4#fractions]],
54655465
as other specs also make use of it.
54665466
(<a href="https://github.com/w3c/csswg-drafts/issues/8027">Issue 8027</a>)
54675467
</ul>

‎css-values-4/Overview.bs

+9-8
Original file line numberDiff line numberDiff line change
@@ -2931,19 +2931,24 @@ Combination of <<position>></h4>
29312931
<h3 id="fractions">
29322932
Flexible lengths: the <<fraction>> type</h3>
29332933

2934-
Fraction values are non-negative <<dimension>>s denoted by
2935-
<dfn id="flex-value">&lt;flex></dfn>.
2936-
The unit identifier is <dfn value for="<flex>" lt="fr|fr unit">fr</dfn>.
2934+
Fraction values are denoted by <dfn id="flex-value">&lt;fraction></dfn>,
2935+
and indicate a value that is some fraction of another reference value.
2936+
A fraction is a <<dimension>>.
2937+
Its unit identifier is <dfn value for="<flex>" lt="fr|fr unit">fr</dfn>.
29372938

29382939
These values specify
29392940
<dfn export lt="flexible length">flexible lengths</dfn>.
29402941
Each length defines a portion of a given space
29412942
which is specified by the context the type is used in.
29422943

2944+
The allowed range of <<fraction>>> values
2945+
<em>always</em> excludes negative values,
2946+
in addition to any explicit ranges that might be specified.
2947+
29432948
Note: <<fraction>> values are not <<length>>s
29442949
(nor are they compatible with <<length>>s, like some <<percentage>> values),
29452950
so they cannot be represented in or
2946-
combined with other unit typesin ''calc()'' expressions.
2951+
combined with other unit types in ''calc()'' expressions.
29472952

29482953
<details class=note>
29492954
<summary><<fraction>> values between 0fr and 1fr have a somewhat special behavior:
@@ -2982,10 +2987,6 @@ Flexible lengths: the <<fraction>> type</h3>
29822987
if fractions are added or removed.
29832988
</details>
29842989

2985-
Note: <<fraction>> values are not <<length>>s
2986-
(nor are they compatible with <<length>>s, like some <<percentage>> values),
2987-
so they cannot be represented in or combined with other unit types in ''calc()'' expressions.
2988-
29892990

29902991
<!--
29912992
████████ ██ ██ ██ ██ ██████ ██████

0 commit comments

Comments
 (0)