Skip to content

Commit 353dadf

Browse files
carlescufinashif
authored andcommitted
scripts: test_plan: Fix issue introduced in 3f77560
The rewrite by ruff seems to wrongly pass a single argument to filter(), as seen in the logs: ``` f.process() File "/home/runner/work/zephyr/zephyr/zephyr/./scripts/ci/test_plan.py", line 145, in process self.find_boards() File "/home/runner/work/zephyr/zephyr/zephyr/./scripts/ci/test_plan.py", line 292, in find_boards self.resolved_files.extend(list(filter(resolved_filter))) ^^^^^^^^^^^^^^^^^^^^^^^ TypeError: filter expected 2 arguments, got 1 ``` Split things up properly to avoid this. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
1 parent 396fcbf commit 353dadf

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

‎scripts/ci/test_plan.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,8 +288,8 @@ def find_boards(self):
288288
# be removed from further consideration
289289
for _, board in matched_boards.items():
290290
relative_board_dir = str(board.dir.relative_to(zephyr_base))
291-
resolved_filter = lambda f, rel_dir=relative_board_dir: rel_dir in f, resolved_files
292-
self.resolved_files.extend(list(filter(resolved_filter)))
291+
rel_resolved_files = [f for f in resolved_files if relative_board_dir in f]
292+
self.resolved_files.extend(rel_resolved_files)
293293

294294
_options = []
295295
if len(matched_boards) > 20:

0 commit comments

Comments
 (0)