From: Yury Norov <ynorov@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@kernel.org>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Alice Ryhl <aliceryhl@google.com>,
	Viktor Malik <vmalik@redhat.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	David Laight <david.laight.linux@gmail.com>,
	linux-kernel@vger.kernel.org
Cc: Yury Norov <ynorov@nvidia.com>,
	"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	Yury Norov <yury.norov@gmail.com>
Subject: [PATCH v2 1/3] rust: uaccess: use INLINE_COPY_TO_USER to guard copy_to_user()
Date: Fri, 24 Apr 2026 22:08:55 -0400	[thread overview]
Message-ID: <20260425020857.356850-2-ynorov@nvidia.com> (raw)
In-Reply-To: <20260425020857.356850-1-ynorov@nvidia.com>

The copy_to_user() rust helper is only needed when the main kernel inlines
the function. It is controlled by INLINE_COPY_TO_USER, but the rust helper
is protected with INLINE_COPY_FROM_USER.

Fix that.

Reported-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
Closes: https://lore.kernel.org/all/746c9c50-20c4-4dc9-a539-bf1310ff9414@kernel.org/
Fixes: d99dc586ca7c7 ("uaccess: decouple INLINE_COPY_FROM_USER and CONFIG_RUST")
Signed-off-by: Yury Norov <ynorov@nvidia.com>
---
 rust/helpers/uaccess.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/rust/helpers/uaccess.c b/rust/helpers/uaccess.c
index d9625b9ee046..aff22f16ab38 100644
--- a/rust/helpers/uaccess.c
+++ b/rust/helpers/uaccess.c
@@ -20,7 +20,9 @@ unsigned long rust_helper__copy_from_user(void *to, const void __user *from, uns
 {
 	return _inline_copy_from_user(to, from, n);
 }
+#endif
 
+#ifdef INLINE_COPY_TO_USER
 __rust_helper
 unsigned long rust_helper__copy_to_user(void __user *to, const void *from, unsigned long n)
 {
-- 
2.51.0

next prev parent reply	other threads:[~2026-04-25  2:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-25  2:08 [PATCH v2 0/3] uaccess: unify inline vs outline copy_{from,to}_user() selection Yury Norov
2026-04-25  2:08 ` Yury Norov [this message]
2026-04-27 14:54   ` [PATCH v2 1/3] rust: uaccess: use INLINE_COPY_TO_USER to guard copy_to_user()\ Alice Ryhl
2026-04-25  2:08 ` [PATCH v2 2/3] uaccess: unify inline vs outline copy_{from,to}_user() selection Yury Norov
2026-04-25  2:08 ` [PATCH v2 3/3] uaccess: minimize INLINE_COPY_USER-related ifdefery Yury Norov
2026-04-27 15:58 ` [PATCH v2 0/3] uaccess: unify inline vs outline copy_{from,to}_user() selection Andrew Morton
2026-04-27 18:47   ` Christophe Leroy (CS GROUP)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260425020857.356850-2-ynorov@nvidia.com \
    --to=ynorov@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=aliceryhl@google.com \
    --cc=chleroy@kernel.org \
    --cc=david.laight.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=tglx@kernel.org \
    --cc=vmalik@redhat.com \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.