From: Ricardo Ribalda <ribalda@chromium.org>
To: Kees Cook <kees@kernel.org>, Dan Carpenter <dan.carpenter@linaro.org>
Cc: linux-media@vger.kernel.org,
Patchwork Integration <patchwork@media-ci.org>
Subject: Re: [v2,0/3] module: Add compile-time check for embedded NUL characters
Date: Wed, 15 Oct 2025 09:33:40 +0200 [thread overview]
Message-ID: <CANiDSCsBAq3Yx4ybarUb_1NkQ-bvfXvWqb-DfqXatkiYJFZWiQ@mail.gmail.com> (raw)
In-Reply-To: <202510141344.E0ABCD2C7@keescook>
Hi Dan
On Tue, 14 Oct 2025 at 22:45, Kees Cook <kees@kernel.org> wrote:
>
> On Tue, Oct 14, 2025 at 08:24:00AM +0200, Ricardo Ribalda wrote:
> > Hi Kees
> >
> > Thanks for the report.
> >
> >
> > On Tue, 14 Oct 2025 at 07:41, Kees Cook <kees@kernel.org> wrote:
> > >
> > >
> > >
> > > On October 13, 2025 1:34:20 PM PDT, Patchwork Integration <patchwork@media-ci.org> wrote:
> > > >Dear Kees Cook:
> > > >
> > > >Thanks for your patches! Unfortunately the Media CI robot detected some
> > > >issues:
> > > >
> > > ># Test static:test-smatch
> > > >
> > > >drivers/media/usb/usbtv/usbtv-core.c:157:1: error: bad constant expression
> > >
> > > Where can I find what this test actually does?
> > >
> > > >For more details, check the full report at:
> > > >https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/85913402/artifacts/report.htm .
> > >
> > > This webserver appears to be misconfigured to send compressed output without the right headers? I can't actually view this URL.
> >
> > I will follow-up with fdo maintainers to figure out what happened.
> > there. On the meantime you can use these url that seems to work:
> > https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/85913402/artifacts/report.txt
> > https://gitlab.freedesktop.org/linux-media/users/patchwork/-/jobs/85913398
> >
> > Basically sparse/smatch do not seem to understand the constant.
>
> Yeah, I managed to find the actual scripts that are run for the
> static-sparse/smatch tests. It looks like those tools aren't correctly
> handling string literals for __builtin_strlen(), which is a constant for
> constant arguments.
>
> So, that's a C parsing bug in those tools (GCC and Clang are fine).
Could you take a look at this patch:
https://patchwork.linuxtv.org/project/linux-media/patch/20251010030610.3032147-3-kees@kernel.org/
Seems that sparse/smatch are not very happy about __builtin_strlen()
Could you fix support for __builtin_strlen() in your tool?
Once Kees lands his patch it will break all the CIs using
sparse/smatch, including media-ci.
Eg:
drivers/media/pci/zoran/zr36060.c:33:1: error: bad constant expression
drivers/media/usb/pvrusb2/pvrusb2-dvb.c:19:1: error: bad constant expression
drivers/media/usb/pvrusb2/pvrusb2-dvb.c:19:1: error: bad constant expression
Thanks :)
>
> -Kees
>
> --
> Kees Cook
--
Ricardo Ribalda
next prev parent reply other threads:[~2025-10-15 7:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 3:06 [PATCH v2 0/3] module: Add compile-time check for embedded NUL characters Kees Cook
2025-10-10 3:06 ` [PATCH v2 1/3] media: dvb-usb-v2: lmedm04: Fix firmware macro definitions Kees Cook
2025-10-10 7:10 ` Mauro Carvalho Chehab
2025-10-10 3:06 ` [PATCH v2 2/3] media: radio: si470x: Fix DRIVER_AUTHOR macro definition Kees Cook
2025-10-10 7:10 ` Mauro Carvalho Chehab
2025-10-10 3:06 ` [PATCH v2 3/3] module: Add compile-time check for embedded NUL characters Kees Cook
2025-10-10 4:19 ` Petr Pavlu
2025-10-21 2:05 ` Aaron Tomlin
[not found] ` <68ed624c.050a0220.3ba739.64ea@mx.google.com>
2025-10-14 5:41 ` [v2,0/3] " Kees Cook
2025-10-14 6:24 ` Ricardo Ribalda
2025-10-14 20:45 ` Kees Cook
2025-10-15 7:33 ` Ricardo Ribalda [this message]
2025-10-20 18:29 ` Kees Cook
2025-10-20 18:35 ` Ricardo Ribalda
2025-10-20 18:51 ` Kees Cook
2025-10-20 18:55 ` Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiDSCsBAq3Yx4ybarUb_1NkQ-bvfXvWqb-DfqXatkiYJFZWiQ@mail.gmail.com \
--to=ribalda@chromium.org \
--cc=dan.carpenter@linaro.org \
--cc=kees@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=patchwork@media-ci.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.