From: Brian Norris <briannorris@chromium.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
	Joe Perches <joe@perches.com>, Andrew Lunn <andrew@lunn.ch>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: list iterator spacing: clang-format vs checkpatch
Date: Thu, 21 Apr 2022 16:53:10 -0700	[thread overview]
Message-ID: <YmHuZjmP9MxkgJ0R@google.com> (raw)
In-Reply-To: <CANiq72mmFn8KUjhcOHhTbWGCktK-HEvAQ+nz8HZhM598XqO2aw@mail.gmail.com>

Hi Miguel,

On Sat, Jan 22, 2022 at 02:16:14PM +0100, Miguel Ojeda wrote:
> On Mon, Jan 17, 2022 at 10:41 PM Miguel Ojeda
> <miguel.ojeda.sandonis@gmail.com> wrote:
> >
> > So it is coming -- the question is whether we wait a bit until LLVM 11
> > is the minimum supported version (nowadays LLVM 10) or we are willing
> > to require LLVM 11.
> 
> LLVM 11 is now the minimum with commit df05c0e9496c ("Documentation:
> Raise the minimum supported version of LLVM to 11.0.0"), so I will
> give this a go.

How's it going? Are you ready to apply this patch?

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 .clang-format | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.clang-format b/.clang-format
index fa959436bcfd..63f0127a409d 100644
--- a/.clang-format
+++ b/.clang-format
@@ -1,6 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0
 #
-# clang-format configuration file. Intended for clang-format >= 4.
+# clang-format configuration file. Intended for clang-format >= 11.
 #
 # For more information, see:
 #
@@ -545,7 +545,7 @@ SpaceAfterTemplateKeyword: true
 SpaceBeforeAssignmentOperators: true
 #SpaceBeforeCtorInitializerColon: true # Unknown to clang-format-5.0
 #SpaceBeforeInheritanceColon: true # Unknown to clang-format-5.0
-SpaceBeforeParens: ControlStatements
+SpaceBeforeParens: ControlStatementsExceptForEachMacros
 #SpaceBeforeRangeBasedForLoopColon: true # Unknown to clang-format-5.0
 SpaceInEmptyParentheses: false
 SpacesBeforeTrailingComments: 1
-- 
2.36.0


  reply	other threads:[~2022-04-21 23:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08  2:00 list iterator spacing: clang-format vs checkpatch Jason A. Donenfeld
2018-10-08  7:31 ` Miguel Ojeda
2018-10-08 15:40   ` Joe Perches
2018-10-08 16:01     ` Miguel Ojeda
2018-10-08 16:06       ` Jason A. Donenfeld
2022-01-17 12:47         ` Jason A. Donenfeld
2022-01-17 18:05           ` Joe Perches
2022-01-17 21:41             ` Miguel Ojeda
2022-01-18  4:25               ` Joe Perches
2022-01-18  9:27             ` David Laight
2022-01-17 21:41           ` Miguel Ojeda
2022-01-22 13:16             ` Miguel Ojeda
2022-04-21 23:53               ` Brian Norris [this message]
2022-04-22 10:57                 ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmHuZjmP9MxkgJ0R@google.com \
    --to=briannorris@chromium.org \
    --cc=Jason@zx2c4.com \
    --cc=andrew@lunn.ch \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).