From: Herve Codina <herve.codina@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Simon Horman <horms@kernel.org>, Lee Jones <lee@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Derek Kiernan <derek.kiernan@amd.com>,
Dragan Cvetic <dragan.cvetic@amd.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Herve Codina <herve.codina@bootlin.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Daniel Machon <daniel.machon@microchip.com>,
UNGLinuxDriver@microchip.com, Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Horatiu Vultur" <horatiu.vultur@microchip.com>,
"Andrew Lunn" <andrew@lunn.ch>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org,
"Allan Nielsen" <allan.nielsen@microchip.com>,
"Steen Hegelund" <steen.hegelund@microchip.com>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Clément Léger" <clement.leger@bootlin.com>
Subject: [PATCH v5 7/8] reset: core: add get_device()/put_device on rcdev
Date: Thu, 8 Aug 2024 17:46:56 +0200 [thread overview]
Message-ID: <20240808154658.247873-8-herve.codina@bootlin.com> (raw)
In-Reply-To: <20240808154658.247873-1-herve.codina@bootlin.com>
From: Clément Léger <clement.leger@bootlin.com>
Since the rcdev structure is allocated by the reset controller drivers
themselves, they need to exists as long as there is a consumer. A call to
module_get() is already existing but that does not work when using
device-tree overlays. In order to guarantee that the underlying reset
controller device does not vanish while using it, add a get_device() call
when retrieving a reset control from a reset controller device and a
put_device() when releasing that control.
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
drivers/reset/core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index dba74e857be6..999c3c41cf21 100644
--- a/drivers/reset/core.c
+++ b/drivers/reset/core.c
@@ -812,6 +812,7 @@ __reset_control_get_internal(struct reset_controller_dev *rcdev,
kref_init(&rstc->refcnt);
rstc->acquired = acquired;
rstc->shared = shared;
+ get_device(rcdev->dev);
return rstc;
}
@@ -826,6 +827,7 @@ static void __reset_control_release(struct kref *kref)
module_put(rstc->rcdev->owner);
list_del(&rstc->list);
+ put_device(rstc->rcdev->dev);
kfree(rstc);
}
--
2.45.0
next prev parent reply other threads:[~2024-08-08 15:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 15:46 [PATCH v5 0/8] Add support for the LAN966x PCI device using a DT overlay Herve Codina
2024-08-08 15:46 ` [PATCH v5 1/8] misc: Add support for LAN966x PCI device Herve Codina
2024-08-13 9:57 ` Greg Kroah-Hartman
2024-09-09 7:45 ` Herve Codina
2024-09-12 17:00 ` Bjorn Helgaas
2024-08-08 15:46 ` [PATCH v5 2/8] MAINTAINERS: Add the Microchip LAN966x PCI driver entry Herve Codina
2024-08-08 15:46 ` [PATCH v5 3/8] mfd: syscon: Add reference counting and device managed support Herve Codina
2024-09-03 15:38 ` Lee Jones
2024-09-03 16:01 ` Herve Codina
2024-09-09 7:52 ` Herve Codina
2024-09-12 14:37 ` Lee Jones
2024-09-23 8:07 ` Herve Codina
2024-08-08 15:46 ` [PATCH v5 4/8] reset: mchp: sparx5: Add MCHP_LAN966X_PCI dependency Herve Codina
2024-08-08 15:46 ` [PATCH v5 5/8] reset: mchp: sparx5: Allow building as a module Herve Codina
2024-08-08 15:46 ` [PATCH v5 6/8] reset: mchp: sparx5: Release syscon when not use anymore Herve Codina
2024-08-08 15:46 ` Herve Codina [this message]
2024-09-02 10:01 ` [PATCH v5 7/8] reset: core: add get_device()/put_device on rcdev Philipp Zabel
2024-08-08 15:46 ` [PATCH v5 8/8] reset: mchp: sparx5: set the dev member of the reset controller Herve Codina
2024-09-02 10:49 ` [PATCH v5 0/8] Add support for the LAN966x PCI device using a DT overlay Philipp Zabel
2024-09-03 8:17 ` Herve Codina
2024-09-03 9:51 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808154658.247873-8-herve.codina@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=clement.leger@bootlin.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=derek.kiernan@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@amd.com \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=horatiu.vultur@microchip.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.