From: Conor Dooley <conor@kernel.org>
To: linux-riscv@lists.infradead.org
Cc: conor@kernel.org, "Conor Dooley" <conor.dooley@microchip.com>,
"Eric Biggers" <ebiggers@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Clément Léger" <cleger@rivosinc.com>,
"Andy Chiu" <andybnac@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/6] Add some validation for vector, vector crypto and fp stuff
Date: Wed, 12 Mar 2025 13:11:43 +0000 [thread overview]
Message-ID: <20250312-abide-pancreas-3576b8c44d2c@spud> (raw)
From: Conor Dooley <conor.dooley@microchip.com>
Yo,
This series is partly leveraging Clement's work adding a validate
callback in the extension detection code so that things like checking
for whether a vector crypto extension is usable can be done like:
has_extension(<vector crypto>)
rather than
has_vector() && has_extension(<vector crypto>)
which Eric pointed out was a poor design some months ago.
The rest of this is adding some requirements to the bindings that
prevent combinations of extensions disallowed by the ISA.
There's a bunch of over-long lines in here, but I thought that the
over-long lines were clearer than breaking them up.
Cheers,
Conor.
(I've been unintentionally sitting on this for a month, hope I
haven't omitted anything as a result)
v4:
- Zvbb -> vector_crypto_validate()
- remove copy-pasta section of commit messages
- Add commentary justifying !EPROBE_DEFER cases
- EPROBE_DEFER where possible (one instance, zve32x check)
v3:
- rebase on v6.14-rc1
- split vector crypto validation patch into vector validation and vector
crypto validation
- fix zve64x requiring extension list to match Eric's PR
v2:
- Fix an inverted clause Clément pointed out
- Add Zvbb validation, that I had missed accidentally
- Drop the todo about checking the number of validation rounds,
I tried in w/ qemu's max cpu and things looked right
CC: Eric Biggers <ebiggers@kernel.org>
CC: Conor Dooley <conor@kernel.org>
CC: Rob Herring <robh@kernel.org>
CC: Krzysztof Kozlowski <krzk+dt@kernel.org>
CC: Paul Walmsley <paul.walmsley@sifive.com>
CC: Palmer Dabbelt <palmer@dabbelt.com>
CC: "Clément Léger" <cleger@rivosinc.com>
CC: Andy Chiu <andybnac@gmail.com>
CC: linux-riscv@lists.infradead.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Conor Dooley (6):
RISC-V: add vector extension validation checks
RISC-V: add vector crypto extension validation checks
RISC-V: add f & d extension validation checks
dt-bindings: riscv: d requires f
dt-bindings: riscv: add vector sub-extension dependencies
dt-bindings: riscv: document vector crypto requirements
.../devicetree/bindings/riscv/extensions.yaml | 85 +++++++++++
arch/riscv/include/asm/cpufeature.h | 3 +
arch/riscv/kernel/cpufeature.c | 140 +++++++++++++-----
3 files changed, 190 insertions(+), 38 deletions(-)
--
2.45.2
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: linux-riscv@lists.infradead.org
Cc: conor@kernel.org, "Conor Dooley" <conor.dooley@microchip.com>,
"Eric Biggers" <ebiggers@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Clément Léger" <cleger@rivosinc.com>,
"Andy Chiu" <andybnac@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/6] Add some validation for vector, vector crypto and fp stuff
Date: Wed, 12 Mar 2025 13:11:43 +0000 [thread overview]
Message-ID: <20250312-abide-pancreas-3576b8c44d2c@spud> (raw)
From: Conor Dooley <conor.dooley@microchip.com>
Yo,
This series is partly leveraging Clement's work adding a validate
callback in the extension detection code so that things like checking
for whether a vector crypto extension is usable can be done like:
has_extension(<vector crypto>)
rather than
has_vector() && has_extension(<vector crypto>)
which Eric pointed out was a poor design some months ago.
The rest of this is adding some requirements to the bindings that
prevent combinations of extensions disallowed by the ISA.
There's a bunch of over-long lines in here, but I thought that the
over-long lines were clearer than breaking them up.
Cheers,
Conor.
(I've been unintentionally sitting on this for a month, hope I
haven't omitted anything as a result)
v4:
- Zvbb -> vector_crypto_validate()
- remove copy-pasta section of commit messages
- Add commentary justifying !EPROBE_DEFER cases
- EPROBE_DEFER where possible (one instance, zve32x check)
v3:
- rebase on v6.14-rc1
- split vector crypto validation patch into vector validation and vector
crypto validation
- fix zve64x requiring extension list to match Eric's PR
v2:
- Fix an inverted clause Clément pointed out
- Add Zvbb validation, that I had missed accidentally
- Drop the todo about checking the number of validation rounds,
I tried in w/ qemu's max cpu and things looked right
CC: Eric Biggers <ebiggers@kernel.org>
CC: Conor Dooley <conor@kernel.org>
CC: Rob Herring <robh@kernel.org>
CC: Krzysztof Kozlowski <krzk+dt@kernel.org>
CC: Paul Walmsley <paul.walmsley@sifive.com>
CC: Palmer Dabbelt <palmer@dabbelt.com>
CC: "Clément Léger" <cleger@rivosinc.com>
CC: Andy Chiu <andybnac@gmail.com>
CC: linux-riscv@lists.infradead.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Conor Dooley (6):
RISC-V: add vector extension validation checks
RISC-V: add vector crypto extension validation checks
RISC-V: add f & d extension validation checks
dt-bindings: riscv: d requires f
dt-bindings: riscv: add vector sub-extension dependencies
dt-bindings: riscv: document vector crypto requirements
.../devicetree/bindings/riscv/extensions.yaml | 85 +++++++++++
arch/riscv/include/asm/cpufeature.h | 3 +
arch/riscv/kernel/cpufeature.c | 140 +++++++++++++-----
3 files changed, 190 insertions(+), 38 deletions(-)
--
2.45.2
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2025-03-12 13:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 13:11 Conor Dooley [this message]
2025-03-12 13:11 ` [PATCH v4 0/6] Add some validation for vector, vector crypto and fp stuff Conor Dooley
2025-03-12 13:11 ` [PATCH v4 1/6] RISC-V: add vector extension validation checks Conor Dooley
2025-03-12 13:11 ` Conor Dooley
2025-03-25 13:16 ` Alexandre Ghiti
2025-03-25 13:16 ` Alexandre Ghiti
2025-03-12 13:11 ` [PATCH v4 2/6] RISC-V: add vector crypto " Conor Dooley
2025-03-12 13:11 ` Conor Dooley
2025-03-25 13:44 ` Alexandre Ghiti
2025-03-25 13:44 ` Alexandre Ghiti
2025-03-12 13:11 ` [PATCH v4 3/6] RISC-V: add f & d " Conor Dooley
2025-03-12 13:11 ` Conor Dooley
2025-03-25 13:48 ` Alexandre Ghiti
2025-03-25 13:48 ` Alexandre Ghiti
2025-03-12 13:11 ` [PATCH v4 4/6] dt-bindings: riscv: d requires f Conor Dooley
2025-03-12 13:11 ` Conor Dooley
2025-03-12 13:11 ` [PATCH v4 5/6] dt-bindings: riscv: add vector sub-extension dependencies Conor Dooley
2025-03-12 13:11 ` Conor Dooley
2025-03-12 13:11 ` [PATCH v4 6/6] dt-bindings: riscv: document vector crypto requirements Conor Dooley
2025-03-12 13:11 ` Conor Dooley
2025-03-25 13:51 ` Alexandre Ghiti
2025-03-25 13:51 ` Alexandre Ghiti
2025-04-03 16:20 ` [PATCH v4 0/6] Add some validation for vector, vector crypto and fp stuff patchwork-bot+linux-riscv
2025-04-03 16:20 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312-abide-pancreas-3576b8c44d2c@spud \
--to=conor@kernel.org \
--cc=andybnac@gmail.com \
--cc=cleger@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=ebiggers@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.