From: John.C.Harrison@Intel.com
To: Intel-Xe@Lists.FreeDesktop.Org
Cc: "John Harrison" <John.C.Harrison@Intel.com>,
"Zhanjun Dong" <zhanjun.dong@intel.com>,
"Alan Previn" <alan.previn.teres.alexis@intel.com>,
"Matt Roper" <matthew.d.roper@intel.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
intel-xe@lists.freedesktop.org
Subject: [PATCH 1/3] drm/xe/guc: Fix capture of steering registers
Date: Thu, 17 Apr 2025 12:52:12 -0700 [thread overview]
Message-ID: <20250417195215.3002210-2-John.C.Harrison@Intel.com> (raw)
In-Reply-To: <20250417195215.3002210-1-John.C.Harrison@Intel.com>
From: John Harrison <John.C.Harrison@Intel.com>
The list of registers to capture on a GPU hang includes some that
require steering. Unfortunately, the flag to say this was being wiped
to due a missing OR on the assignment of the next flag field.
Fix that.
Fixes: b170d696c1e2 ("drm/xe/guc: Add XE_LP steered register lists")
Cc: Zhanjun Dong <zhanjun.dong@intel.com>
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-xe@lists.freedesktop.org
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
---
drivers/gpu/drm/xe/xe_guc_capture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_capture.c b/drivers/gpu/drm/xe/xe_guc_capture.c
index f6d523e4c5fe..9095618648bc 100644
--- a/drivers/gpu/drm/xe/xe_guc_capture.c
+++ b/drivers/gpu/drm/xe/xe_guc_capture.c
@@ -359,7 +359,7 @@ static void __fill_ext_reg(struct __guc_mmio_reg_descr *ext,
ext->reg = XE_REG(extlist->reg.__reg.addr);
ext->flags = FIELD_PREP(GUC_REGSET_STEERING_NEEDED, 1);
- ext->flags = FIELD_PREP(GUC_REGSET_STEERING_GROUP, slice_id);
+ ext->flags |= FIELD_PREP(GUC_REGSET_STEERING_GROUP, slice_id);
ext->flags |= FIELD_PREP(GUC_REGSET_STEERING_INSTANCE, subslice_id);
ext->regname = extlist->name;
}
--
2.49.0
next prev parent reply other threads:[~2025-04-17 19:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 19:52 [PATCH 0/3] Fixes for steered register capture John.C.Harrison
2025-04-17 19:52 ` John.C.Harrison [this message]
2025-04-17 20:15 ` [PATCH 1/3] drm/xe/guc: Fix capture of steering registers Matt Roper
2025-04-17 20:55 ` Dong, Zhanjun
2025-04-17 19:52 ` [PATCH 2/3] drm/xe/guc: Use the steering flag when printing registers John.C.Harrison
2025-04-17 20:17 ` Matt Roper
2025-04-17 20:45 ` John Harrison
2025-04-17 20:47 ` Matt Roper
2025-04-17 19:52 ` [PATCH 3/3] drm/xe/guc: Cache DSS info when creating capture register list John.C.Harrison
2025-04-17 20:31 ` Matt Roper
2025-04-17 20:52 ` John Harrison
2025-04-17 21:33 ` John.C.Harrison
2025-04-22 17:03 ` Matt Roper
2025-04-17 20:30 ` ✓ CI.Patch_applied: success for Fixes for steered register capture Patchwork
2025-04-17 20:30 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-17 20:31 ` ✓ CI.KUnit: success " Patchwork
2025-04-17 20:40 ` ✓ CI.Build: " Patchwork
2025-04-17 20:42 ` ✓ CI.Hooks: " Patchwork
2025-04-17 20:43 ` ✓ CI.checksparse: " Patchwork
2025-04-17 21:02 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-17 21:38 ` ✓ CI.Patch_applied: success for Fixes for steered register capture (rev2) Patchwork
2025-04-17 21:38 ` ✗ CI.checkpatch: warning " Patchwork
2025-04-17 21:40 ` ✓ CI.KUnit: success " Patchwork
2025-04-17 21:48 ` ✓ CI.Build: " Patchwork
2025-04-17 21:50 ` ✓ CI.Hooks: " Patchwork
2025-04-17 21:52 ` ✓ CI.checksparse: " Patchwork
2025-04-17 22:17 ` ✓ Xe.CI.BAT: " Patchwork
2025-04-18 14:22 ` ✗ Xe.CI.Full: failure for Fixes for steered register capture Patchwork
2025-04-18 16:31 ` ✗ Xe.CI.Full: failure for Fixes for steered register capture (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417195215.3002210-2-John.C.Harrison@Intel.com \
--to=john.c.harrison@intel.com \
--cc=Intel-Xe@Lists.FreeDesktop.Org \
--cc=alan.previn.teres.alexis@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=zhanjun.dong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.