From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Tejun Heo <tj@kernel.org>, Josef Bacik <josef@toxicpanda.com>,
Christian Brauner <christian@brauner.io>,
linux-block@vger.kernel.org, cgroups@vger.kernel.org
Subject: [PATCH 4/4] block: don't autoload drivers on blk-cgroup configuration
Date: Wed, 23 Apr 2025 07:37:42 +0200 [thread overview]
Message-ID: <20250423053810.1683309-5-hch@lst.de> (raw)
In-Reply-To: <20250423053810.1683309-1-hch@lst.de>
Loading a driver just to configure blk-cgroup doesn't make sense, as that
assumes and already existing device.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
block/blk-cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index e172aeda4183..ce93706555c5 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -797,7 +797,7 @@ int blkg_conf_open_bdev(struct blkg_conf_ctx *ctx)
return -EINVAL;
input = skip_spaces(input);
- bdev = blkdev_get_no_open(MKDEV(major, minor), true);
+ bdev = blkdev_get_no_open(MKDEV(major, minor), false);
if (!bdev)
return -ENODEV;
if (bdev_is_partition(bdev)) {
--
2.47.2
next prev parent reply other threads:[~2025-04-23 5:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 5:37 don't autoload block drivers on stat (and cgroup configuration) Christoph Hellwig
2025-04-23 5:37 ` [PATCH 1/4] block: move blkdev_{get,put} _no_open prototypes out of blkdev.h Christoph Hellwig
2025-04-23 5:37 ` [PATCH 2/4] block: remove the backing_inode variable in bdev_statx Christoph Hellwig
2025-04-23 5:37 ` [PATCH 3/4] block: don't autoload drivers on stat Christoph Hellwig
2025-04-23 5:37 ` Christoph Hellwig [this message]
2025-04-23 15:06 ` don't autoload block drivers on stat (and cgroup configuration) Tejun Heo
2025-04-24 9:39 ` Christian Brauner
2025-04-24 13:35 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423053810.1683309-5-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=christian@brauner.io \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.