From: Adrian Moreno <amorenoz@redhat.com>
To: netdev@vger.kernel.org
Cc: aconole@redhat.com, echaudro@redhat.com, horms@kernel.org,
i.maximets@ovn.org, dev@openvswitch.org,
Adrian Moreno <amorenoz@redhat.com>,
Ido Schimmel <idosch@nvidia.com>, Yotam Gigi <yotam.gi@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next v9 03/10] net: psample: skip packet copy if no listeners
Date: Thu, 4 Jul 2024 10:56:54 +0200 [thread overview]
Message-ID: <20240704085710.353845-4-amorenoz@redhat.com> (raw)
In-Reply-To: <20240704085710.353845-1-amorenoz@redhat.com>
If nobody is listening on the multicast group, generating the sample,
which involves copying packet data, seems completely unnecessary.
Return fast in this case.
Reviewed-by: Aaron Conole <aconole@redhat.com>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
---
net/psample/psample.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/net/psample/psample.c b/net/psample/psample.c
index b37488f426bc..1c76f3e48dcd 100644
--- a/net/psample/psample.c
+++ b/net/psample/psample.c
@@ -376,6 +376,10 @@ void psample_sample_packet(struct psample_group *group, struct sk_buff *skb,
void *data;
int ret;
+ if (!genl_has_listeners(&psample_nl_family, group->net,
+ PSAMPLE_NL_MCGRP_SAMPLE))
+ return;
+
meta_len = (in_ifindex ? nla_total_size(sizeof(u16)) : 0) +
(out_ifindex ? nla_total_size(sizeof(u16)) : 0) +
(md->out_tc_valid ? nla_total_size(sizeof(u16)) : 0) +
--
2.45.2
next prev parent reply other threads:[~2024-07-04 8:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 8:56 [PATCH net-next v9 00/10] net: openvswitch: Add sample multicasting Adrian Moreno
2024-07-04 8:56 ` [PATCH net-next v9 01/10] net: psample: add user cookie Adrian Moreno
2024-07-04 8:56 ` [PATCH net-next v9 02/10] net: sched: act_sample: add action cookie to sample Adrian Moreno
2024-07-04 8:56 ` Adrian Moreno [this message]
2024-07-04 8:56 ` [PATCH net-next v9 04/10] net: psample: allow using rate as probability Adrian Moreno
2024-07-04 8:56 ` [PATCH net-next v9 05/10] net: openvswitch: add psample action Adrian Moreno
2024-07-04 8:56 ` [PATCH net-next v9 06/10] net: openvswitch: store sampling probability in cb Adrian Moreno
2024-07-04 8:56 ` [PATCH net-next v9 07/10] selftests: openvswitch: add psample action Adrian Moreno
2024-07-04 8:56 ` [PATCH net-next v9 08/10] selftests: openvswitch: add userspace parsing Adrian Moreno
2024-07-04 8:57 ` [PATCH net-next v9 09/10] selftests: openvswitch: parse trunc action Adrian Moreno
2024-07-04 8:57 ` [PATCH net-next v9 10/10] selftests: openvswitch: add psample test Adrian Moreno
2024-07-05 9:49 ` [PATCH net-next v9 00/10] net: openvswitch: Add sample multicasting Adrián Moreno
[not found] ` <f73l6iiysjulc6eb2j3gm7ng4gkpe2uebnjiaun4fhhaogyp23@u3hi32mc4jvb>
2024-07-05 13:58 ` Adrián Moreno
2024-07-06 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240704085710.353845-4-amorenoz@redhat.com \
--to=amorenoz@redhat.com \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yotam.gi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.