From: Muna Sinada <muna.sinada@oss.qualcomm.com>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org,
Muna Sinada <muna.sinada@oss.qualcomm.com>
Subject: [PATCH wireless-next v4 3/3] wifi: mac80211: VLAN traffic in multicast path
Date: Tue, 25 Mar 2025 14:31:25 -0700 [thread overview]
Message-ID: <20250325213125.1509362-4-muna.sinada@oss.qualcomm.com> (raw)
In-Reply-To: <20250325213125.1509362-1-muna.sinada@oss.qualcomm.com>
Currently for MLO, sending out multicast frames on each link is handled by
mac80211 only when IEEE80211_HW_MLO_MCAST_MULTI_LINK_TX flag is not set.
Dynamic VLAN multicast traffic utilizes software encryption.
Due to this, mac80211 should handle transmitting multicast frames on
all links for multicast VLAN traffic.
Signed-off-by: Muna Sinada <muna.sinada@oss.qualcomm.com>
---
v4: no changes
v3: rebase to cleanly apply to wireless-next
v2:
- move clearing links for AP_VLAN into seperate function:
ieee80211_apvlan_link_clear()
- remove use of goto
- replaced "master" terminalogy with "AP bss"
- update Author signoff to new email
---
net/mac80211/tx.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 20179db88c4a..b6d6d0658e14 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -4526,8 +4526,10 @@ netdev_tx_t ieee80211_subif_start_xmit(struct sk_buff *skb,
IEEE80211_TX_CTRL_MLO_LINK_UNSPEC,
NULL);
} else if (ieee80211_vif_is_mld(&sdata->vif) &&
- sdata->vif.type == NL80211_IFTYPE_AP &&
- !ieee80211_hw_check(&sdata->local->hw, MLO_MCAST_MULTI_LINK_TX)) {
+ ((sdata->vif.type == NL80211_IFTYPE_AP &&
+ !ieee80211_hw_check(&sdata->local->hw, MLO_MCAST_MULTI_LINK_TX)) ||
+ ((sdata->vif.type == NL80211_IFTYPE_AP_VLAN) &&
+ !sdata->wdev.use_4addr))) {
ieee80211_mlo_multicast_tx(dev, skb);
} else {
normal:
--
2.34.1
prev parent reply other threads:[~2025-03-25 21:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 21:31 [PATCH wireless-next v4 0/3] wifi: mac80211: MLO handling for Dynamic VLAN Muna Sinada
2025-03-25 21:31 ` [PATCH wireless-next v4 1/3] wifi: mac80211: Add link iteration macro for link data Muna Sinada
2025-03-25 21:31 ` [PATCH wireless-next v4 2/3] wifi: mac80211: Create separate links for VLAN interfaces Muna Sinada
2025-03-25 21:31 ` Muna Sinada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250325213125.1509362-4-muna.sinada@oss.qualcomm.com \
--to=muna.sinada@oss.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.