From: Miri Korenblit <miriam.rachel.korenblit@intel.com>
To: linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: [PATCH iwlwifi-next 01/15] wifi: iwlwifi: mld: remove one more error in unallocated BAID
Date: Tue, 6 May 2025 22:40:48 +0300 [thread overview]
Message-ID: <20250506194102.3407967-2-miriam.rachel.korenblit@intel.com> (raw)
In-Reply-To: <20250506194102.3407967-1-miriam.rachel.korenblit@intel.com>
Since the FW is the one to assign an ID to a BA, it can happen that
the FW sends a bar_frame_release_notif before the driver had the chance to
allocate the BAID.
Convert the IWL_FW_CHECK into a regular debug print.
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Message-Id: <20250506223834.101423dfcc07.Id5aa779b6a0a0d51cc127ba561c01ffc6594a178@changeid>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
---
drivers/net/wireless/intel/iwlwifi/mld/agg.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mld/agg.c b/drivers/net/wireless/intel/iwlwifi/mld/agg.c
index 393cc0e27052..bda488ae9eec 100644
--- a/drivers/net/wireless/intel/iwlwifi/mld/agg.c
+++ b/drivers/net/wireless/intel/iwlwifi/mld/agg.c
@@ -124,10 +124,12 @@ void iwl_mld_handle_bar_frame_release_notif(struct iwl_mld *mld,
rcu_read_lock();
baid_data = rcu_dereference(mld->fw_id_to_ba[baid]);
- if (!IWL_FW_CHECK(mld, !baid_data,
- "Got valid BAID %d but not allocated, invalid BAR release!\n",
- baid))
+ if (!baid_data) {
+ IWL_DEBUG_HT(mld,
+ "Got valid BAID %d but not allocated\n",
+ baid);
goto out_unlock;
+ }
if (IWL_FW_CHECK(mld, tid != baid_data->tid ||
sta_id > mld->fw->ucode_capa.num_stations ||
--
2.34.1
next prev parent reply other threads:[~2025-05-06 19:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 19:40 [PATCH iwlwifi-next 00/15] wifi: iwlwifi: updates - 2025-05-06 Miri Korenblit
2025-05-06 19:40 ` Miri Korenblit [this message]
2025-05-06 19:40 ` [PATCH iwlwifi-next 02/15] wifi: iwlwifi: add range response version 10 support Miri Korenblit
2025-05-06 19:40 ` [PATCH iwlwifi-next 03/15] wifi: iwlwifi: Add a new version for sta config command Miri Korenblit
2025-05-06 19:40 ` [PATCH iwlwifi-next 04/15] wifi: iwlwifi: Add a new version for mac " Miri Korenblit
2025-05-06 19:40 ` [PATCH iwlwifi-next 05/15] wifi: iwlwifi: Add support for a new version for link " Miri Korenblit
2025-05-06 19:40 ` [PATCH iwlwifi-next 06/15] wifi: iwlwifi: pcie: remove iwl_trans_pcie_gen2_send_hcmd Miri Korenblit
2025-05-06 19:40 ` [PATCH iwlwifi-next 07/15] wifi: iwlwifi: fix thermal code compilation with -Werror=cast-qual Miri Korenblit
2025-05-06 19:40 ` [PATCH iwlwifi-next 08/15] wifi: iwlwifi: mvm: use a radio/system specific power budget Miri Korenblit
2025-05-06 19:40 ` [PATCH iwlwifi-next 09/15] wifi: iwlwifi: mld: " Miri Korenblit
2025-05-06 19:40 ` [PATCH iwlwifi-next 10/15] wifi: iwlwifi: mld: avoid init-after-queue Miri Korenblit
2025-05-06 19:40 ` [PATCH iwlwifi-next 11/15] wifi: iwlwifi: mld: call thermal exit without wiphy lock held Miri Korenblit
2025-05-06 19:40 ` [PATCH iwlwifi-next 12/15] wifi: iwlwifi: cfg: remove 6 GHz from ht40_bands Miri Korenblit
2025-05-06 19:41 ` [PATCH iwlwifi-next 13/15] wifi: iwlwifi: cfg: inline HT params Miri Korenblit
2025-05-06 19:41 ` [PATCH iwlwifi-next 14/15] wifi: iwlwifi: pcie: remove 0x2726 devices Miri Korenblit
2025-05-06 19:41 ` [PATCH iwlwifi-next 15/15] wifi: iwlwifi: add JF1/JF2 RF for dynamic FW building Miri Korenblit
-- strict thread matches above, loose matches on Subject: below --
2025-05-05 18:56 [PATCH iwlwifi-next 00/15] wifi: iwlwifi: updates - 2025-05-05 Miri Korenblit
2025-05-05 18:56 ` [PATCH iwlwifi-next 01/15] wifi: iwlwifi: mld: remove one more error in unallocated BAID Miri Korenblit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250506194102.3407967-2-miriam.rachel.korenblit@intel.com \
--to=miriam.rachel.korenblit@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.