Skip to content

Conversation

alexeagle
Copy link
Collaborator

@alexeagle alexeagle commented Oct 2, 2025

Copy link

github-actions bot commented Oct 2, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@alexeagle alexeagle changed the title DNL: experiment to see what breaks without @icu Oct 2, 2025
@alexeagle alexeagle requested review from fhanau and guybedford October 2, 2025 01:52
@alexeagle alexeagle marked this pull request as ready for review October 2, 2025 01:53
@alexeagle alexeagle requested review from a team as code owners October 2, 2025 01:53
@alexeagle
Copy link
Collaborator Author

@fhanau I suppose the internal repo needs a similar change, wherever it is assuming //external:icu label points to this particular repo.

@fhanau
Copy link
Contributor

fhanau commented Oct 2, 2025

@fhanau I suppose the internal repo needs a similar change, wherever it is assuming //external:icu label points to this particular repo.

The change here is fine – no internal changes are needed, but there's an internal CI issue (I'll merge this once that's resolved).

@fhanau fhanau merged commit 1e8a049 into main Oct 2, 2025
21 of 22 checks passed
@fhanau fhanau deleted the alexeagle-patch-1 branch October 2, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants