Skip to content

fix: add language and dialects to no-use-before-define #19808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

fasttime
Copy link
Member

@fasttime fasttime commented Jun 1, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This PR adds the missing language and dialects properties to the meta object of no-use-before-define. The rule was updated to support TypeScript syntax in #19566, but we forgot to add the new fields.

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 1, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Jun 1, 2025
Copy link

netlify bot commented Jun 1, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 3d6f513
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/683c0c331a86fd0008a69d22
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Jun 1, 2025
@fasttime fasttime marked this pull request as ready for review June 1, 2025 08:26
@fasttime fasttime requested a review from a team as a code owner June 1, 2025 08:26
@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Jun 1, 2025
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 1, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic moved this from Implementing to Merge Candidates in Triage Jun 1, 2025
@mdjermanovic
Copy link
Member

Since these fields are not documented and not used yet, I think this doesn't require a patch release.

@fasttime fasttime merged commit 1ba3318 into main Jun 2, 2025
30 checks passed
@fasttime fasttime deleted the fix-no-use-before-define branch June 2, 2025 21:17
@github-project-automation github-project-automation bot moved this from Merge Candidates to Complete in Triage Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules
3 participants