feat: prune suppressions for non-existent files #19825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
✅ Deploy Preview for docs-eslint canceled.
|
fasttime
added
the
accepted
nzakas
reviewed
Jun 6, 2025
| @@ -112,6 +112,14 @@ class SuppressionsService { | |||
| } | |||
| } | |||
|
|
|||
| for (const file of Object.keys(suppressions)) { | |||
There was a problem hiding this comment.
I believe you should be able to do this within the loop above, otherwise we end up looping over keys twice. Can you take a look? (ref: #19778 (comment))
There was a problem hiding this comment.
This is not possible because deleted files are not marked as unused since they are not included in the lint.
nzakas
approved these changes
Jun 10, 2025
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
What changes did you make? (Give an overview)
When using --prune-suppressions, remove suppressions for files that don't exist on disk.
Fixes #19778
Is there anything you'd like reviewers to focus on?