GODRIVER-3770 Remove libasan from gssapi tests in CI - #2293
Merged
prestonvasquez merged 1 commit intoJan 21, 2026
Merged
prestonvasquez merged 1 commit into
prestonvasquez merged 1 commit into
Conversation
github-actions
Bot
added
the
review-priority-normal
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves AddressSanitizer configuration from the Makefile to the shell script to enable platform-specific ASan setup for GSSAPI tests, addressing the lack of ASan support on Windows/MinGW while maintaining memory error detection on Linux.
Changes:
- Removed hardcoded ASan flags from the Makefile's
evg-test-enterprise-authtarget - Added Linux-specific libasan installation logic in the GSSAPI test setup script
- Configured ASan environment variables conditionally based on Linux package manager availability
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| etc/run-enterprise-gssapi-test.sh | Adds platform-specific libasan installation and ASan environment variable configuration for Linux systems |
| Makefile | Removes ASan flags from the enterprise auth test target, delegating sanitizer setup to the shell script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prestonvasquez
added
review-priority-urgent
prestonvasquez
requested review from
qingyang-hu
and removed request for
matthewdale
January 20, 2026 23:37
Contributor
API Change ReportNo changes found! |
qingyang-hu
previously approved these changes
Jan 21, 2026
prestonvasquez
force-pushed
the
cicd/godriver-3770-install-libasan
branch
from
January 21, 2026 15:28
8328f3d to
6ae3d0e
Compare
github-actions
Bot
added
the
review-priority-normal
prestonvasquez
force-pushed
the
cicd/godriver-3770-install-libasan
branch
from
January 21, 2026 15:57
6ae3d0e to
a9a64ee
Compare
prestonvasquez
force-pushed
the
cicd/godriver-3770-install-libasan
branch
from
January 21, 2026 15:58
a9a64ee to
1909943
Compare
qingyang-hu
approved these changes
Jan 21, 2026
This was referenced Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defer testing with AddressSanitizer for GSSAPI.