summary | log | graphiclog1 | graphiclog2 | commit | commitdiff | tree | refs | edit | fork
raw | patch | inline | side by side (parent: eedd22c)
interface: never pass DefaultImageName to Driver constructor
authorSven Verdoolaege <sven.verdoolaege@gmail.com>
Sun, 19 Oct 2025 17:39:05 +0000 (19 19:39 +0200)
committerSven Verdoolaege <sven.verdoolaege@gmail.com>
Sat, 22 Nov 2025 14:26:17 +0000 (22 15:26 +0100)
Only optionally passing the argument was introduced
in isl-0.13-113-ga71ce41310 (update for removal of DefaultImageName
Driver constructor argument, Sat Aug 30 18:16:47 2014 +0200),
but the parameter was removed before clang 3.5,
which is documented as the minimal supported version.

Signed-off-by: Sven Verdoolaege <sven.verdoolaege@gmail.com>
interface/extract_interface.cc patch | blob | blame | history
m4/ax_detect_clang.m4 patch | blob | blame | history

diff --git a/interface/extract_interface.cc b/interface/extract_interface.cc
index 6b16664..4989bfb 100644 (file)
--- a/interface/extract_interface.cc
+++ b/interface/extract_interface.cc
@@ -171,18 +171,10 @@ struct MyASTConsumer : public ASTConsumer {
        }
 };
 
-#if defined(DRIVER_CTOR_TAKES_DEFAULTIMAGENAME)
-static Driver *construct_driver(const char *binary, DiagnosticsEngine &Diags)
-{
-       return new Driver(binary, llvm::sys::getDefaultTargetTriple(),
-                           "", Diags);
-}
-#else
 static Driver *construct_driver(const char *binary, DiagnosticsEngine &Diags)
 {
        return new Driver(binary, llvm::sys::getDefaultTargetTriple(), Diags);
 }
-#endif
 
 namespace clang { namespace driver { class Job; } }
 
diff --git a/m4/ax_detect_clang.m4 b/m4/ax_detect_clang.m4
index a17080a..4ceeba4 100644 (file)
--- a/m4/ax_detect_clang.m4
+++ b/m4/ax_detect_clang.m4
@@ -103,12 +103,6 @@ AC_EGREP_HEADER([ArrayRef.*CommandLineArgs],
                [Define if CompilerInvocation::CreateFromArgs takes
                 ArrayRef])
        ])
-AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <clang/Driver/Driver.h>]], [[
-       using namespace clang;
-       DiagnosticsEngine *Diags;
-       new driver::Driver("", "", "", *Diags);
-]])], [AC_DEFINE([DRIVER_CTOR_TAKES_DEFAULTIMAGENAME], [],
-             [Define if Driver constructor takes default image name])])
 AC_EGREP_HEADER([void HandleTopLevelDecl\(], [clang/AST/ASTConsumer.h],
        [AC_DEFINE([HandleTopLevelDeclReturn], [void],
                   [Return type of HandleTopLevelDeclReturn])
Integer set library