Noobie in bash scripting

Question

I just started doing some bash script from few days I am not getting any output when running this bash script in terminal please correct me here:

Code:

#!/bin/bash
echo "Usage:"
echo -n "Please enter t/n"
read o
echo -n "IP"
read ip
traceroute () {
  traceroute $ip
}
nmap () {
  nmap -T4 -A -v $ip
}
if [[ "$o" = "t" ]]
then
  traceroute
elif [[ "$o" = "n" ]]
then
  nmap
else
  echo "Usage:"
  echo "Please enter t/n"
  exit 1
fi

Could you describe how you are trying to run this script, what are the access rights and what output you get when running the script? — Kamil
– Kamil, Commented Nov 3, 2016 at 14:03
also, I don't think you meant to write /n but rather \n (the correct symbol for newlines) — Aserre
– Aserre, Commented Nov 3, 2016 at 14:04

Ipor Sircer · Accepted Answer · 2016-11-03 14:08:38Z

2

You've made an infinite loop. Choose a solution (1st one is preferred)

don't use traceroute and nmap as function name
use the full path of /usr/bin/traceroute and /usr/bin/nmap

answered Nov 3, 2016 at 14:08

Ipor Sircer

3,1693 gold badges12 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

The Pizza Overlord · Accepted Answer · 2016-11-03 14:29:10Z

1

The bit immediately after 'read ip' isn't necessary, as it actually doesn't do anything (so far as I can tell).

#!/bin/bash
echo "Usage:"
echo -n "Please enter t/n"
read o
echo -n "IP"
read ip
if [[ "$o" = "t" ]]
then
  traceroute $ip
elif [[ "$o" = "n" ]]
then
  nmap -T4 -A -v $ip
else
  echo "Usage:"
  echo "Please enter t/n"
  exit 1
fi

The above amended code works but could do with some formatting to make it look a little nicer.

answered Nov 3, 2016 at 14:29

The Pizza Overlord

1364 bronze badges

Collectives™ on Stack Overflow

Noobie in bash scripting

2 Answers 2

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Related