Compare a string array component with a character

Question

I have this function: int foo(char *string, int x, int y) Example input is: -.-..-...-. The program tokenises the string with the delimiter -. Then it counts the . in the tokens. The problem is the db variable does not change. After the counting the db has to be higher than x and lower than y. So -.-..-...- 2 3, the solution has to be 2.

    char *token;
    int length;
    int i;
    int db=0;
    int igaz=0;
    int j=1;

    token = strtok(string, "-");
    length = strlen(token);

    while(token != NULL)
    {
        length = strlen(token);

        for(i=0; i<length; i++);
        {
            if(token[i] == '.')
            //if(strcmp(token[i],'.')==0)
            {
                db++;
            }
        }

        if(db >= x && db <= y)
        {
            igaz++;
        }
        db=0;

        token = strtok(NULL, "-");
        j++;

    }
    return igaz;

@Bela Karalyos : I've edited the question for spelling and grammar, but this is still not a minimal working example, see how to ask. Additionally, please add some example inputs & expected outputs. — SIGSTACKFAULT
– SIGSTACKFAULT, Commented Nov 29, 2016 at 16:10
Also if you are sure that string just has '-' and '.', why do you use for loop. db = strlen(token); right? — MayurK
– MayurK, Commented Nov 29, 2016 at 16:12
There is a ; at the end of a for instruction: for(i=0; i<length; i++);! The following block is only executed when i is length... — Serge Ballesta
– Serge Ballesta, Commented Nov 29, 2016 at 16:27

MayurK · Accepted Answer · 2016-11-29 17:51:27Z

1

There are multiple problems in your code. 1. For loop with semi colon.

for(i=0; i<length; i++);

This will just make the thread loop. But it will not execute the for loop body.

strlen() will return string length excluding '\0' at the end. So your for loop should be from 0 to length as below.

for(i=0; i<=length; i++);

For loop is unnecessary as string has only '-' and '.'

This will do that.

int foo(char *string, int x, int y)
{
    char *token;
    int igaz =0;
    int db   = 0;

    token = strtok(string, "-");

    while(token != NULL)
    {
       db = strlen(token);


       if(db >= x && db <= y)
       {
           igaz++;
       }

       token = strtok(NULL, "-");

    }
    return igaz;

}

edited Nov 29, 2016 at 17:51

answered Nov 29, 2016 at 16:19

MayurK

1,9671 gold badge17 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Béla Karalyos Over a year ago

Thank you! It works. With the next line: if(token[i] == '.'). What could be the problem?

MayurK Over a year ago

@BélaKaralyos I updated the answer. Hope you find answer to your question.

Béla Karalyos Over a year ago

God, i did not even notice that, it did not give me any error, or warning.. It is working now!

Collectives™ on Stack Overflow

Compare a string array component with a character

1 Answer 1

3 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Related