Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updiff: Fix for memory leak in git_patch #348
Merged
Conversation
|
|
alexband
commented
Feb 25, 2014
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
beeble commentedFeb 21, 2014
This pull request will fix a memory leak,
that occurs while iterating through patches.
It's quite major issue, my machine run out of memory in couple of minutes.
Please take a look at this fragment of valgrind log.
==6056== 154,660,050 (15,076,512 direct, 139,583,538 indirect) bytes in 52,349 blocks are definitely lost in loss record 788 of 788
==6056== at 0x4C2B590: calloc (vg_replace_malloc.c:618)
==6056== by 0x71159C6: git__calloc (util.h:36)
==6056== by 0x7115D97: diff_patch_alloc_from_diff (diff_patch.c:104)
==6056== by 0x711726A: git_patch_from_diff (diff_patch.c:622)
==6056== by 0x6ED71AF: diff_get_patch_byindex (diff.c:140)
==6056== by 0x55F1DA: PyEval_EvalFrameEx (in /usr/bin/python2.7)
==6056== by 0x55F7B9: PyEval_EvalFrameEx (in /usr/bin/python2.7)
==6056== by 0x55F7B9: PyEval_EvalFrameEx (in /usr/bin/python2.7)
==6056== by 0x55F7B9: PyEval_EvalFrameEx (in /usr/bin/python2.7)
==6056== by 0x55F7B9: PyEval_EvalFrameEx (in /usr/bin/python2.7)
==6056== by 0x55F7B9: PyEval_EvalFrameEx (in /usr/bin/python2.7)
==6056== by 0x55F7B9: PyEval_EvalFrameEx (in /usr/bin/python2.7)