The Wayback Machine - https://web.archive.org/web/20201103205854/https://github.com/angular/angular.io/pull/3378
Skip to content
This repository has been archived by the owner. It is now read-only.

/ angular.io Archived

[WIP] docs(universal): add guide #3378

Merged
merged 12 commits into from Mar 31, 2017
Merged

[WIP] docs(universal): add guide #3378

merged 12 commits into from Mar 31, 2017

Conversation

@wardbell
Copy link
Contributor

@wardbell wardbell commented Mar 16, 2017

WIP - Do not merge
Guide to using Angular Universal (an Angular v.4 feature)
@googlebot googlebot added the CLA: yes label Mar 16, 2017
@filipesilva
filipesilva reviewed Mar 29, 2017
View changes
Copy link
Member

@filipesilva filipesilva left a comment

I like this guide a lot. It explains clearly where universal helps, reasons to use it and doesn't oversell it.

The file structure presented might need to be adjusted somewhat when we standardize AOT setups within the example folders, but we haven't yet so I don't want to prescribe any changes.

I have a question though.... why the dual SystemJS/Webpack setup instead of just Webpack? We already have a Webpack only guide so I don't think it would be a problem to have another one.

I should mention that @FrozenPandaz has a couple of PRs for @ngtools/webpack that might simplify the presented usage:

Overall solid guide, cheers!
wardbell and others added 12 commits Mar 16, 2017
@wardbell @filipesilva
docs(universal): add guide
Loading status checks…
efe60f6
@steveschmitt @filipesilva
gulpfile: Replace 'rm -rf' with 'node rimraf' so install-example-angu…
Loading status checks…
ae360db 
…lar will work on Windows
@steveschmitt @filipesilva
Get universal working
Loading status checks…
79813d1
@steveschmitt @filipesilva
doc wip
Loading status checks…
4be03ac
@steveschmitt @filipesilva
gulpfile: Add platform-server to install-example-angular
Loading status checks…
ba5d6f5
@steveschmitt @filipesilva
Update toh code in universal sample - remove moduleId
Loading status checks…
3b257d0
@steveschmitt @filipesilva
Update typescript to 2.2.1 when we install-example-angular --build
Loading status checks…
5bb7556
@steveschmitt @filipesilva
move example files; add graphs
Loading status checks…
11ad74d
@steveschmitt @filipesilva
demo and docs wip
Loading status checks…
b5be62e
@steveschmitt @filipesilva
doc wip
Loading status checks…
52d6a1d
@steveschmitt @filipesilva
Fix toc
Loading status checks…
af8d9e1
@filipesilva
add toc, link
Loading status checks…
530ab60
@filipesilva filipesilva force-pushed the IdeaBlade:docs-universal branch from fbf98c0 to 530ab60 Mar 31, 2017
@googlebot
Copy link

@googlebot googlebot commented Mar 31, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
1 similar comment
@googlebot
Copy link

@googlebot googlebot commented Mar 31, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
@googlebot googlebot added CLA: no and removed CLA: yes labels Mar 31, 2017
@filipesilva
Copy link
Member

@filipesilva filipesilva commented Mar 31, 2017

@steveschmitt I'll be merging this PR as is for now. We may have to revisit in the future to adjust the build setup.
@filipesilva filipesilva merged commit 5738c4b into angular:master Mar 31, 2017
1 of 2 checks passed
1 of 2 checks passed
cla/google CLAs are signed, but unable to verify author consent
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@webmutation
Copy link

@webmutation webmutation commented Apr 4, 2017

Trying to run the universal example, how exactly is this supposed to run? Tried to simply run the build returns this

src/main-aot.ts(3,36): error TS2307: Cannot find module '../aot/src/app/app.module.ngfactory'.
src/uni/server-aot.ts(4,42): error TS2307: Cannot find module '../../aot/src/uni/app.server.ngfactory'.
src/uni/server-aot.ts(5,26): error TS7016: Could not find a declaration file for module 'express'. 'cli-toh-universal/angular.io/public/docs/_examples/node_modules/express/index.js' implicitly has an 'any' type.
src/uni/server-aot.ts(21,60): error TS7006: Parameter 'req' implicitly has an 'any' type.
src/uni/server-aot.ts(21,65): error TS7006: Parameter 'res' implicitly has an 'any' type.
src/uni/server-aot.ts(26,34): error TS7006: Parameter 'req' implicitly has an 'any' type.
src/uni/server-aot.ts(26,39): error TS7006: Parameter 'res' implicitly has an 'any' type.
src/uni/server-aot.ts(26,44): error TS7006: Parameter 'next' implicitly has an 'any' type.
src/uni/server-aot.ts(30,54): error TS7006: Parameter 'err' implicitly has an 'any' type.
src/uni/universal-engine.ts(12,54): error TS2304: Cannot find name 'Request'.

So I must be doing something wrong running the build or there is a different way to run the example? I see this tagged as WIP, is it actually runnable or still WIP?
filipesilva added a commit to IdeaBlade/angular that referenced this pull request May 15, 2017
@filipesilva
docs(aio): migrate platform-server guide
b014cc4 
Original guide: angular/angular.io#3378

cc @wardbell @foxandcss
@filipesilva filipesilva mentioned this pull request May 15, 2017
Closed
2 of 3 tasks complete
filipesilva added a commit to IdeaBlade/angular that referenced this pull request May 15, 2017
@filipesilva
docs(aio): migrate platform-server guide
903d2f3 
Original guide: angular/angular.io#3378

cc @wardbell @Foxandxss
filipesilva added a commit to IdeaBlade/angular.io that referenced this pull request May 15, 2017
@filipesilva
Revert "docs(universal): add guide (angular#3378)"
7995774 
This reverts commit 5738c4b.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: no
5 participants
@wardbell @googlebot @filipesilva @webmutation @steveschmitt
You can’t perform that action at this time.