Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 31 million developers.
Sign up
Pinned
1,499 contributions in the last year
Activity overview
Contributed to
mozilla-mobile/focus-android,
mozilla-mobile/fenix,
mozilla-l10n/focus-android-l10n
and 5 other
repositories
Contribution activity
April 2019
Created a pull request in mozilla-mobile/android-components that received 2 comments
Closes #2392 - Add ability for progress bar to be displayed on top of…
… toolbar Hi @pocmo this has UX now :) mozilla-mobile/fenix#1049 (comment) I tested it in Fenix and I don't think we need a drawable attr here, I a…
+50
−3
•
2
comments
- No issue: Only set toolbar behavior for non custom tab sessions
- Closes #2004 - Set base alpha of quick action overlay to visible
- Closes #2000 - Don't flash LeakCanary setting in release builds
- No issue: Add back status/nav flags after fullscreen exit
- For #1206 - call fullScreenFeature onBackPressed
- Closes #1993 - Set toolbar behavior in onStart for browser resumed case
- No issue: Use setting to show history autocomplete suggestion
- Closes #1948 - Shows bookmark url if title is null
- Closes #469 - Changes Library String
- No issue: Update quick action divider to neutral faded
- For #1922 - Open bookmark in new tab menu should open and show new tab
- Closes #1914 - Removes incomplete actions from Custom Tab Menu
- Closes #1855 - Remove haptic feedback on tabs button
- For #1601 - Bookmark icon should change visually if page is bookmarked
- No issue: Fixed visibility bugs in quick action sheet
- Closes #1912 - Quick action bottom sheet should fade in
- No issue: Update bottom margin of quick action sheet to 12dp
- Closes #1894 - Fixes Help Page Navigation
- Closes #1879 - Create toolbar background drawable instead of view
- For #1759 - Try to change copy URL to plainText
- For #1593 - Remove evenodd from vector files
- Closes #1835 - Do not crash because of snackbar
- Closes #1798, Closes #1581 Corrects divider views and padding for too…
- No issue: Add instructions to pre-push hook
- Closes #1798, Closes #1581 Corrects divider views and padding for toolbar
- Some pull requests not shown.
- Tab selection for collections
- For #1970: Fixes Firefox Preview icon for older devices
- For #1917: Hides search suggestions in shortcuts when needed
- Closes #1972: Sets search term on browserToolbar
- Bookmark sync
- Fixes #1868: Corrects private browsing myths link
- For #1923: Title of bookmarks folder is not displayed
- Cleanup build-time warnings
- For #1205: Adds search term to EditToolbar
- For #1714: Updates product to Firefox Preview
- Fix for 2428 from a-c
- Fixes tab sizing
- No issue: Use GeckoView fetch implementation for A-S libs (megazord)
- Fixes #1899 - Update GeckoView version to 68.0.20190422094240.
- Fixes #1890 - Remove unused strings
- No issue: Fix crash on bookmark folder selection and Snackbar color
- For #1817: Multi-select toolbar changes when minimized
- Updates tab visual style
- Fixes #1683: Only show/hide keyboard in search fragment
- Fix #1770: Share icon from quick action bar poorly rasterized
- Fixes #1828 - Adds an empty tab state
- Only set the engine's theme when it is instantiated
- For #1719: tracking protection icon in quick settings is almost invis…
- Fixes #1430 - Implements UX feedback for the FenixSnackbar
- For #668: Restyles custom tabs
- Some pull request reviews not shown.
Created an issue in mozilla-mobile/fenix that received 9 comments
[Bug] Can add the exact same site to bookmarks many times, duplicates
Should we not add duplicate bookmarks and instead maybe inform the user that the bookmark already exists?
9
comments
- [Bug] Toolbar locked in expanded state after onResume
- Bottom sheet should fade in
- [Bug] Opening "Help" page in Private Mode displays "0" in tab counter
- Quick Action Sheet should have some click response (like a ripple)
- Progressbar for custom tabs should be at the bottom
- After a fling, recyclerview takes 2 clicks to activate
- [Bug] With no active session, settings will pop to home on background

