The Wayback Machine - https://web.archive.org/web/20200519110710/https://github.com/ethereum/solidity/issues/8541
Skip to content

/ solidity

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor checks on Contracts #8541

Open
chriseth opened this issue Mar 26, 2020 · 0 comments
Open

Refactor checks on Contracts #8541

chriseth opened this issue Mar 26, 2020 · 0 comments
Labels
good first issue
Projects
Solidity

Comments

@chriseth
Copy link
Contributor

@chriseth chriseth commented Mar 26, 2020

The type checker contains multiple occurrences of

		if (noErrors)
			for (Source const* source: m_sourceOrder)
				if (source->ast)
					for (ASTPointer<ASTNode> const& node: source->ast->nodes())
						if (ContractDefinition* contract = dynamic_cast<ContractDefinition*>(node.get()))

These should be extracted into some helper "forAllContracts" or something like that, which takes a lambda.
@elenadimitrova elenadimitrova added this to New issues in Solidity via automation May 14, 2020
@elenadimitrova elenadimitrova moved this from New issues to Implementation Backlog in Solidity May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue
1 participant
@chriseth
You can’t perform that action at this time.