The Wayback Machine - https://web.archive.org/web/20200914223516/https://github.com/TheAlgorithms/Python/pull/2329
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowest_common_ancestor.py static type checking #2329

Merged
merged 18 commits into from Aug 21, 2020
Merged

lowest_common_ancestor.py static type checking #2329

merged 18 commits into from Aug 21, 2020
+107 −50

Conversation

@kanthuc
Copy link
Contributor

kanthuc commented Aug 18, 2020 •
edited

Describe your change:

Added static type checking to lowest_common_ancestor.py towards issue #2128. Also includes changes from PR #2303.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
kanthuc and others added 14 commits Aug 8, 2020
@kanthuc
adding static type checking to basic_binary_tree.py
Loading status checks…
aefe913
@kanthuc
Add static type checking to functions with None return type
Loading status checks…
e676647
@kanthuc
Applying code review comments
Loading status checks…
6310890
@kanthuc
Added missing import statement
Loading status checks…
0439180
@kanthuc
fix spaciing
Loading status checks…
5005cbc
@kanthuc
"cleaned up depth_of_tree"
Loading status checks…
039cdb3
@cclauss
Add doctests and then streamline display() and is_full_binary_tree()
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f1c86af
@kanthuc
added static typing to lazy_segment_tree.py
052f408
@kanthuc
Merge branch 'master' of https://github.com/kanthuc/Python
d5a446e 
pull from master
@kanthuc
pull from upstream repo
Loading status checks…
40371aa
@kanthuc
added missing import statement
Loading status checks…
8682782
@kanthuc
modified variable names for left and right elements
Loading status checks…
15b1f62
@kanthuc
added static typing to lowest_common_ancestor.py
fae825f
@kanthuc
fixed formatting
Loading status checks…
a548612
@TravisBuddy
Copy link

TravisBuddy commented Aug 18, 2020

Hey @kanthuc,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 01014280-e104-11ea-a6dd-d374b9ca78b0
@kanthuc
Merge branch 'master' into lowest_common_ancestor.py-static-type-chec…
Loading status checks…
cfc71df 
…king

merge from master
@cclauss
cclauss requested changes Aug 18, 2020
View changes
data_structures/binary_tree/lowest_common_ancestor.py Outdated Show resolved Hide resolved
data_structures/binary_tree/lowest_common_ancestor.py Outdated Show resolved Hide resolved
data_structures/binary_tree/lowest_common_ancestor.py Outdated Show resolved Hide resolved
data_structures/binary_tree/lowest_common_ancestor.py Outdated Show resolved Hide resolved
data_structures/binary_tree/lazy_segment_tree.py Outdated Show resolved Hide resolved
data_structures/binary_tree/lazy_segment_tree.py Outdated Show resolved Hide resolved
data_structures/binary_tree/lazy_segment_tree.py Outdated Show resolved Hide resolved
data_structures/binary_tree/lazy_segment_tree.py Outdated Show resolved Hide resolved
data_structures/binary_tree/lowest_common_ancestor.py Outdated Show resolved Hide resolved
data_structures/binary_tree/lowest_common_ancestor.py Outdated Show resolved Hide resolved
@cclauss
Copy link
Member

cclauss commented Aug 18, 2020

Please add doctests to function’s where possible.
@kanthuc
modified files to meet style guidelines, edited docstrings and added …
Loading status checks…
dbff1f4 
…some doctests
@cclauss
cclauss approved these changes Aug 20, 2020
View changes
Copy link
Member

cclauss left a comment

LGTM
@cclauss
Copy link
Member

cclauss commented Aug 20, 2020

We can merge when Travis tests are passing.
kanthuc added 2 commits Aug 20, 2020
@kanthuc
added and fixed doctests in lazy_segment_tree.py
Loading status checks…
1496a2d
@kanthuc
fixed errors in doctests
Loading status checks…
34cdf3d
@cclauss cclauss merged commit 2eaacee into TheAlgorithms:master Aug 21, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@kanthuc @TravisBuddy @cclauss
You can’t perform that action at this time.