build: setup prettier in repository#23497
Closed
devversion wants to merge 3 commits intoangular:masterfrom
Closed
Conversation
google-cla
bot
added
the
cla: yes
devversion
force-pushed
the
build/enable-prettier
branch
from
3fa9f51 to
80ab4a2
Compare
Sets up prettier in the `yarn ng-dev format` command so that we can format the code consistently.
Reformats all tracked files with prettier so that formatting is consistent across the repo.
Whenever a commit is being created, the `yarn ng-dev format changed` command is being executed. This means that the formatter does not need to be run manually.
devversion
force-pushed
the
build/enable-prettier
branch
from
80ab4a2 to
7b2825c
Compare
Splaktar
approved these changes
Sep 30, 2021
Contributor
Splaktar
left a comment
Splaktar
left a comment
There was a problem hiding this comment.
LGTM
If we run into some instances where we see conflicting rules, https://github.com/prettier/tslint-config-prettier can help with this.
Contributor
|
Closing since this is merge conflict city and we can just regenerate a fresh PR whenever we're ready to merge it right away |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits