The Wayback Machine - https://web.archive.org/web/20211017081056/https://github.com/TheAlgorithms/Python/pull/5091
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Euler problem_092 #5091

Merged
merged 5 commits into from Oct 16, 2021
Merged

Project Euler problem_092 #5091

merged 5 commits into from Oct 16, 2021
+93 −0

Conversation

@srishtik2310
Copy link
Contributor

@srishtik2310 srishtik2310 commented Oct 6, 2021

Describe your change:

added solution for problem 092 of project Euler

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
srishtik2310 and others added 3 commits Oct 6, 2021
@srishtik2310
adde solution to problem 092
ad21975
@srishtik2310
Merge branch 'TheAlgorithms:master' into master
0907cdf
@srishtik2310
added solution to problem 092
bdef112
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 6, 2021
View changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
project_euler/problem_092/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_092/sol1.py Outdated Show resolved Hide resolved
project_euler/problem_092/sol1.py Outdated Show resolved Hide resolved
@srishtik2310
fixed the pre-comit shebang issue
32a0b7f
@srishtik2310
Merge branch 'TheAlgorithms:master' into master
ddf69be
@srishtik2310
Copy link
Contributor Author

@srishtik2310 srishtik2310 commented Oct 8, 2021

I have fixed the pre-commit failing issue due to shebang. Please check
poyea
poyea approved these changes Oct 11, 2021
View changes
Copy link
Member

@poyea poyea left a comment

Thank you for your pull request!🤩
@poyea poyea self-assigned this Oct 11, 2021
poyea
poyea approved these changes Oct 16, 2021
View changes
@poyea poyea merged commit 7ef2e4d into TheAlgorithms:master Oct 16, 2021
4 checks passed
@srishtik2310
Copy link
Contributor Author

@srishtik2310 srishtik2310 commented Oct 16, 2021

This was a great experience to get to know how to contribute to large repositories. That you so much for the opportunity.
@poyea
Copy link
Member

@poyea poyea commented Oct 16, 2021

project_euler\problem_092\sol1.py:35: error: Missing return statement
@srishtik2310 could you fix this in a new PR?
@srishtik2310
Copy link
Contributor Author

@srishtik2310 srishtik2310 commented Oct 16, 2021

I am unable to understand the error. Are you saying that on line 35 there should be a return statement? Because on line 35 there is a new function defined. It would be great if you could elaborate a bit.
@poyea poyea mentioned this pull request Oct 16, 2021
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@srishtik2310 @poyea