diff options
| author | wenlunpeng <wenlunpeng@uniontech.com> | 2024-09-23 16:39:44 +0800 |
|---|---|---|
| committer | Chris Li <sparse@chrisli.org> | 2025-09-25 07:28:08 -0700 |
| commit | bb97bcbd4f7e00896ee447752dfa59bf302c7d17 (patch) | |
| tree | 434fbaeb056897244c9220f5d0cef2b6631d8633 | |
| parent | 366ad4b2fa3e8361001a08b3719881b6d7c87e90 (diff) | |
| download | sparse-dev-bb97bcbd4f7e00896ee447752dfa59bf302c7d17.tar.gz | |
fix: Skip if symbol have no op when handle_qualifiers
Missing s->op will cause a SIGSEGV when trying to get s->op->type.
I encountered the issue when building with sparse in a linux kernel tree
containing a vendor network driver. A simple `make` will success but a
`make C=2` will exit with exit-code 139. The coredump shows that s->op
here is NULL when dealing with a source code line like:
u8 *byte;
Lines like this exist everywhere. I cannot figure out why just this file
breaks sparse. But I think the NULL judge is needed here.
Signed-off-by: wenlunpeng <wenlunpeng@uniontech.com>
Signed-off-by: Chris Li <sparse@chrisli.org>
| -rw-r--r-- | parse.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -1531,7 +1531,7 @@ static struct token *handle_qualifiers(struct token *t, struct decl_state *ctx) { while (token_type(t) == TOKEN_IDENT) { struct symbol *s = lookup_keyword(t->ident, NS_TYPEDEF); - if (!s) + if (!s || !s->op) break; if (!(s->op->type & (KW_ATTRIBUTE | KW_QUALIFIER))) break; |