aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
authorLuc Van Oostenryck <luc.vanoostenryck@gmail.com>2016-12-07 17:13:24 +0100
committerChristopher Li <sparse@chrisli.org>2017-02-13 09:34:46 +0800
commita0886db12307d2633b04ec44342099a2955794a5 (patch)
treec18df7caf796801fb1109dc1165622f00b2ee92e
parent5425db10d4d35895ba3ca390478c624233ec027d (diff)
downloadsparse-dev-a0886db12307d2633b04ec44342099a2955794a5.tar.gz
simplify '(x || 1)' to '1'
There is simplifications for: (x && 0) => 0 (x && 1) => x (x || 0) => x but the fourth case '(x || 1)' is missing. This patch add the missing simplification and a small test case. Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> Signed-off-by: Christopher Li <sparse@chrisli.org>
-rw-r--r--simplify.c7
-rw-r--r--validation/optim/bool-simplify.c51
2 files changed, 57 insertions, 1 deletions
diff --git a/simplify.c b/simplify.c
index b7329aff..ca5bfb65 100644
--- a/simplify.c
+++ b/simplify.c
@@ -370,6 +370,11 @@ static int simplify_constant_rightside(struct instruction *insn)
long long value = insn->src2->value;
switch (insn->opcode) {
+ case OP_OR_BOOL:
+ if (value == 1)
+ return replace_with_pseudo(insn, insn->src2);
+ goto case_neutral_zero;
+
case OP_SUB:
if (value) {
insn->opcode = OP_ADD;
@@ -379,9 +384,9 @@ static int simplify_constant_rightside(struct instruction *insn)
/* Fall through */
case OP_ADD:
case OP_OR: case OP_XOR:
- case OP_OR_BOOL:
case OP_SHL:
case OP_LSR:
+ case_neutral_zero:
if (!value)
return replace_with_pseudo(insn, insn->src1);
return 0;
diff --git a/validation/optim/bool-simplify.c b/validation/optim/bool-simplify.c
new file mode 100644
index 00000000..e0ff1c2d
--- /dev/null
+++ b/validation/optim/bool-simplify.c
@@ -0,0 +1,51 @@
+int and_0(int a)
+{
+ return a && 0;
+}
+
+int and_1(int a)
+{
+ return a && 1;
+}
+
+int or_0(int a)
+{
+ return a || 0;
+}
+
+int or_1(int a)
+{
+ return a || 1;
+}
+
+/*
+ * check-name: bool-simplify
+ * check-command: test-linearize -Wno-decl $file
+ *
+ * check-output-start
+and_0:
+.L0:
+ <entry-point>
+ ret.32 $0
+
+
+and_1:
+.L2:
+ <entry-point>
+ ret.32 %arg1
+
+
+or_0:
+.L4:
+ <entry-point>
+ ret.32 %arg1
+
+
+or_1:
+.L6:
+ <entry-point>
+ ret.32 $1
+
+
+ * check-output-end
+ */