diff options
| author | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2017-03-12 00:45:37 +0100 |
|---|---|---|
| committer | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2017-11-17 10:04:37 +0100 |
| commit | accf7112191ba29f0366c8a10332a8a63644db50 (patch) | |
| tree | 6185f5a5cd930942bdc22e3e21b954a43aaaf518 | |
| parent | f8f27931b9b1118363b364b04fb09526c62d21fb (diff) | |
| download | sparse-dev-accf7112191ba29f0366c8a10332a8a63644db50.tar.gz | |
llvm: fix type in comparison with an address constant
Since sparse's constant are typeless comparing a pointer with
an address constant lack correct type information.
Fix this by casting the constant to the same type as the LHS.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
| -rw-r--r-- | sparse-llvm.c | 3 | ||||
| -rw-r--r-- | validation/backend/compare-with-null.c | 12 |
2 files changed, 13 insertions, 2 deletions
diff --git a/sparse-llvm.c b/sparse-llvm.c index 01a9ae22..c41781f3 100644 --- a/sparse-llvm.c +++ b/sparse-llvm.c @@ -578,9 +578,8 @@ static void output_op_compare(struct function *fn, struct instruction *insn) char target_name[64]; lhs = pseudo_to_value(fn, insn, insn->src1); - if (insn->src2->type == PSEUDO_VAL) - rhs = LLVMConstInt(LLVMTypeOf(lhs), insn->src2->value, 1); + rhs = constant_value(insn->src2->value, LLVMTypeOf(lhs)); else rhs = pseudo_to_value(fn, insn, insn->src2); diff --git a/validation/backend/compare-with-null.c b/validation/backend/compare-with-null.c new file mode 100644 index 00000000..e23562bc --- /dev/null +++ b/validation/backend/compare-with-null.c @@ -0,0 +1,12 @@ +int tstv(void *p) { return !p; } +int cmpv(void *p) { return p == ((void*)0); } + +int tsti(int *p) { return !p; } +int cmpi(int *p) { return p == ((int *)0); } +int cmpx(int *p) { return p == ((void*)0); } + +/* + * check-name: compare-with-null + * check-command: sparsec -Wno-decl -c $file -o tmp.o + * check-output-ignore + */ |