diff options
| author | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2017-01-29 11:48:08 +0100 |
|---|---|---|
| committer | Christopher Li <sparse@chrisli.org> | 2017-02-13 09:34:45 +0800 |
| commit | c6bbdaf57222d77d9c64b53b784372f8bfe70eda (patch) | |
| tree | 027d33becee71c6ee1dc210d092a5995e82d50d4 | |
| parent | 66b1f578780f432367da7d82e245f3fe30bc5b87 (diff) | |
| download | sparse-dev-c6bbdaf57222d77d9c64b53b784372f8bfe70eda.tar.gz | |
cleanup kill_instruction()
No functional changes:
- factorize out the '->bb = NULL' and '|= REPEAT_CSE'.
- fall through the switch cases for ternary/bunary/unary ops.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Signed-off-by: Christopher Li <sparse@chrisli.org>
| -rw-r--r-- | simplify.c | 47 |
1 files changed, 21 insertions, 26 deletions
@@ -188,54 +188,49 @@ void kill_instruction(struct instruction *insn) return; switch (insn->opcode) { + case OP_SEL: + case OP_RANGE: + kill_use(&insn->src3); + /* fall through */ + case OP_BINARY ... OP_BINCMP_END: - insn->bb = NULL; - kill_use(&insn->src1); kill_use(&insn->src2); - repeat_phase |= REPEAT_CSE; - return; + /* fall through */ case OP_CAST: case OP_SCAST: case OP_FPCAST: case OP_PTRCAST: case OP_NOT: case OP_NEG: - insn->bb = NULL; kill_use(&insn->src1); - repeat_phase |= REPEAT_CSE; - return; + break; case OP_PHI: clear_phi(insn); - insn->bb = NULL; - repeat_phase |= REPEAT_CSE; - return; + break; case OP_SYMADDR: - insn->bb = NULL; - repeat_phase |= REPEAT_CSE | REPEAT_SYMBOL_CLEANUP; - return; + repeat_phase |= REPEAT_SYMBOL_CLEANUP; + break; - case OP_SEL: - case OP_RANGE: - insn->bb = NULL; - repeat_phase |= REPEAT_CSE; - kill_use(&insn->src1); - kill_use(&insn->src2); - kill_use(&insn->src3); - return; case OP_BR: + if (!insn->bb_true || !insn->bb_false) + break; + /* fall through */ + case OP_COMPUTEDGOTO: - insn->bb = NULL; - repeat_phase |= REPEAT_CSE; - if (insn->bb_true && insn->bb_false) - kill_use(&insn->cond); - return; + kill_use(&insn->cond); + break; case OP_ENTRY: + default: /* ignore */ return; } + + insn->bb = NULL; + repeat_phase |= REPEAT_CSE; + return; } /* |