diff options
| author | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2018-01-31 12:56:44 +0100 |
|---|---|---|
| committer | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2018-02-01 15:23:25 +0100 |
| commit | 56641060b08a51d582c6ebb6b2ce45c84b8ac467 (patch) | |
| tree | 01b44266b8e28fe454a15461444aaf985f62def6 /validation | |
| parent | 35e71b0279ae0b58518a52bf21ee66b57f965c0f (diff) | |
| download | sparse-dev-56641060b08a51d582c6ebb6b2ce45c84b8ac467.tar.gz | |
add testcases for duplicated warning about invalid types
Once a invalid type is present in some sub-expression,
every upper level of the expression has an invalid type
but we should only warn about the innermost/root error.
However, this is not currently the case and invalid types
can create duplicated warnings, sometimes even a succession
of such warning.
Add some testcases to catch such situations.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Diffstat (limited to 'validation')
| -rw-r--r-- | validation/bad-type-twice0.c | 14 | ||||
| -rw-r--r-- | validation/bad-type-twice1.c | 17 | ||||
| -rw-r--r-- | validation/bad-type-twice2.c | 19 |
3 files changed, 50 insertions, 0 deletions
diff --git a/validation/bad-type-twice0.c b/validation/bad-type-twice0.c new file mode 100644 index 00000000..2dbc91b0 --- /dev/null +++ b/validation/bad-type-twice0.c @@ -0,0 +1,14 @@ +static int foo(a) +{ + return a ? : 1; +} + +/* + * check-name: bad-type-twice0 + * check-known-to-fail + * + * check-error-start +bad-type-twice0.c:3:16: error: incorrect type in conditional +bad-type-twice0.c:3:16: got incomplete type a + * check-error-end + */ diff --git a/validation/bad-type-twice1.c b/validation/bad-type-twice1.c new file mode 100644 index 00000000..2f4e2838 --- /dev/null +++ b/validation/bad-type-twice1.c @@ -0,0 +1,17 @@ +static unsigned long foo(unsigned long val, void *ref) +{ + if (val >= ref) + val = 0; + return val; +} + +/* + * check-name: bad-type-twice1 + * check-known-to-fail + * + * check-error-start +bad-type-twice1.c:3:17: error: incompatible types for operation (>=) +bad-type-twice1.c:3:17: left side has type unsigned long [unsigned] val +bad-type-twice1.c:3:17: right side has type void *ref + * check-error-end + */ diff --git a/validation/bad-type-twice2.c b/validation/bad-type-twice2.c new file mode 100644 index 00000000..916e8202 --- /dev/null +++ b/validation/bad-type-twice2.c @@ -0,0 +1,19 @@ +extern type_t fun(int); + +int foo(int x, int y) +{ + return ((int)fun(y)) + x; +} + +/* + * check-name: bad-type-twice2 + * check-known-to-fail + * + * check-error-start +bad-type-twice2.c:1:8: warning: 'type_t' has implicit type +bad-type-twice2.c:1:15: error: Expected ; at end of declaration +bad-type-twice2.c:1:15: error: got fun +bad-type-twice2.c:5:22: error: undefined identifier 'fun' +bad-type-twice2.c:5:18: error: cast from unknown type + * check-error-end + */ |