aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/pinctrl
diff options
authorDrew Fustini <dfustini@tenstorrent.com>2024-10-08 18:16:46 -0700
committerLinus Walleij <linus.walleij@linaro.org>2024-10-09 14:42:07 +0200
commit7027e36f55f663c2248e8a2d67b94e34cab0ac7f (patch)
tree03371ebfc794cbe150bcbc0a8d5d52c13d3b947a /drivers/pinctrl
parent2694868880705e8f6bb61b24b1b25adc42a4a217 (diff)
downloadath-7027e36f55f663c2248e8a2d67b94e34cab0ac7f.tar.gz
pinctrl: th1520: Fix return value for unknown pin error
Fix th1520_pinctrl_dt_node_to_map() to set the return value before jumping to free_configs when an unknown pin error occurs. Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/r/202410022336.xyWlV0Tf-lkp@intel.com/ Signed-off-by: Drew Fustini <dfustini@tenstorrent.com> Link: https://lore.kernel.org/20241008-th1520-pinctrl-fixes-v3-1-5b60db446a49@tenstorrent.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
-rw-r--r--drivers/pinctrl/pinctrl-th1520.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/pinctrl/pinctrl-th1520.c b/drivers/pinctrl/pinctrl-th1520.c
index 9331f44624809..265a75a78d5a4 100644
--- a/drivers/pinctrl/pinctrl-th1520.c
+++ b/drivers/pinctrl/pinctrl-th1520.c
@@ -499,6 +499,7 @@ static int th1520_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
nmaps = rollback;
dev_err(thp->pctl->dev, "%pOFn.%pOFn: unknown pin '%s'\n",
np, child, pinname);
+ ret = -EINVAL;
goto free_configs;
}