aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/pinctrl
diff options
authorHui Wang <hui.wang@canonical.com>2025-03-27 11:16:00 +0800
committerLinus Walleij <linus.walleij@linaro.org>2025-04-15 09:42:15 +0200
commite64c0ff0d5d85791fbcd126ee558100a06a24a97 (patch)
tree9eae7f40f74e567a3116860dfb88db162fe362ef /drivers/pinctrl
parent0af2f6be1b4281385b618cb86ad946eded089ac8 (diff)
downloadath-e64c0ff0d5d85791fbcd126ee558100a06a24a97.tar.gz
pinctrl: imx: Return NULL if no group is matched and found
Currently if no group is matched and found, this function will return the last grp to the caller, this is not expected, it is supposed to return NULL in this case. Fixes: e566fc11ea76 ("pinctrl: imx: use generic pinctrl helpers for managing groups") Signed-off-by: Hui Wang <hui.wang@canonical.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> Link: https://lore.kernel.org/20250327031600.99723-1-hui.wang@canonical.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
-rw-r--r--drivers/pinctrl/freescale/pinctrl-imx.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
index 842a1e6cbfc41..18de313285404 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
@@ -37,16 +37,16 @@ static inline const struct group_desc *imx_pinctrl_find_group_by_name(
struct pinctrl_dev *pctldev,
const char *name)
{
- const struct group_desc *grp = NULL;
+ const struct group_desc *grp;
int i;
for (i = 0; i < pctldev->num_groups; i++) {
grp = pinctrl_generic_get_group(pctldev, i);
if (grp && !strcmp(grp->grp.name, name))
- break;
+ return grp;
}
- return grp;
+ return NULL;
}
static void imx_pin_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s,