aboutsummaryrefslogtreecommitdiffstats
path: root/drivers
diff options
authorDmitry Torokhov <dmitry.torokhov@gmail.com>2026-06-26 17:42:10 -0700
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2026-06-26 22:22:42 -0700
commitd85589879f19ad8514c508709865f064be761df5 (patch)
tree8c6965446003b3683f73e601f8fd49b592b49be1 /drivers
parentd577e46785d45484b2ab7e7309c49b18764bf56c (diff)
downloadath-d85589879f19ad8514c508709865f064be761df5.tar.gz
Revert "Input: rmi4 - fix register descriptor address calculation"
The register descriptor presence register is a packet register, which means its bytes share a single RMI address. It does not occupy consecutive addresses, and the register structure that follows it is located at the next RMI address (presence_address + 1), not (presence_address + presence_size). Revert the incorrect address calculation introduced in commit a98518e72439. Reported-by: "Barry K. Nathan" <barryn@pobox.com> Tested-by: "Barry K. Nathan" <barryn@pobox.com> Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/input/rmi4/rmi_driver.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index 49a59da6a8411..a28eef1b765e5 100644
--- a/drivers/input/rmi4/rmi_driver.c
+++ b/drivers/input/rmi4/rmi_driver.c
@@ -643,7 +643,7 @@ int rmi_read_register_desc(struct rmi_device *d, u16 addr,
ret = rmi_read_block(d, addr, buf, size_presence_reg);
if (ret)
return ret;
- addr += size_presence_reg;
+ ++addr;
if (buf[0] == 0) {
if (size_presence_reg < 3)