diff options
| author | Ingyu Jang <ingyujang25@korea.ac.kr> | 2026-05-15 04:32:14 +0900 |
|---|---|---|
| committer | Andrew Morton <akpm@linux-foundation.org> | 2026-05-28 21:24:57 -0700 |
| commit | 4d80db59de9c7b52f75d8f32005dafc8d64658b0 (patch) | |
| tree | da980bce034272ff1701a89992230246ba19aee5 /lib | |
| parent | f5b1910e23f1233c8d4185268b2e659df2bc5dbf (diff) | |
| download | ath-4d80db59de9c7b52f75d8f32005dafc8d64658b0.tar.gz | |
error-inject: use IS_ERR() check for debugfs_create_file()
debugfs_create_file() returns an error pointer on failure, never NULL, so
the !file check in ei_debugfs_init() never triggers and the
debugfs_remove() cleanup cannot run.
Use IS_ERR() and propagate the actual error via PTR_ERR().
Link: https://lore.kernel.org/20260514193214.2432769-1-ingyujang25@korea.ac.kr
Signed-off-by: Ingyu Jang <ingyujang25@korea.ac.kr>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/error-inject.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/error-inject.c b/lib/error-inject.c index f3d1b70be605c..32f3d1ca9ea23 100644 --- a/lib/error-inject.c +++ b/lib/error-inject.c @@ -219,9 +219,9 @@ static int __init ei_debugfs_init(void) dir = debugfs_create_dir("error_injection", NULL); file = debugfs_create_file("list", 0444, dir, NULL, &ei_fops); - if (!file) { + if (IS_ERR(file)) { debugfs_remove(dir); - return -ENOMEM; + return PTR_ERR(file); } return 0; |