diff options
| author | Frederic Weisbecker <frederic@kernel.org> | 2024-12-31 18:07:12 +0100 |
|---|---|---|
| committer | Boqun Feng <boqun.feng@gmail.com> | 2025-03-09 10:42:49 -0700 |
| commit | fcb83ae12343443bbe7a65cc1b12951bae5cb0c6 (patch) | |
| tree | ff73a4b181e0e4071ac06d3f1a35fe02587aefa1 | |
| parent | c37cf754ebf58ebbc7100216c78ab2b96d5503da (diff) | |
| download | linux-dev.2025.03.09a.tar.gz | |
Revert "rcu/nocb: Fix rcuog wake-up from offline softirq"rcu/devnext.2025.03.09anextdev.2025.03.09a
This reverts commit f7345ccc62a4b880cf76458db5f320725f28e400.
swake_up_one_online() has been removed because hrtimers can now assign
a proper online target to hrtimers queued from offline CPUs. Therefore
remove the related hackery.
Link: https://lore.kernel.org/all/20241231170712.149394-4-frederic@kernel.org/
Reviewed-by: Usama Arif <usamaarif642@gmail.com>
Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
| -rw-r--r-- | kernel/rcu/tree_nocb.h | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h index 91dfb5ab7a189f..4a954ecf1c36e8 100644 --- a/kernel/rcu/tree_nocb.h +++ b/kernel/rcu/tree_nocb.h @@ -554,19 +554,13 @@ static void __call_rcu_nocb_wake(struct rcu_data *rdp, bool was_alldone, rcu_nocb_unlock(rdp); wake_nocb_gp_defer(rdp, RCU_NOCB_WAKE_LAZY, TPS("WakeLazy")); - } else if (!irqs_disabled_flags(flags) && cpu_online(rdp->cpu)) { + } else if (!irqs_disabled_flags(flags)) { /* ... if queue was empty ... */ rcu_nocb_unlock(rdp); wake_nocb_gp(rdp, false); trace_rcu_nocb_wake(rcu_state.name, rdp->cpu, TPS("WakeEmpty")); } else { - /* - * Don't do the wake-up upfront on fragile paths. - * Also offline CPUs can't call swake_up_one_online() from - * (soft-)IRQs. Rely on the final deferred wake-up from - * rcutree_report_cpu_dead() - */ rcu_nocb_unlock(rdp); wake_nocb_gp_defer(rdp, RCU_NOCB_WAKE, TPS("WakeEmptyIsDeferred")); |