diff options
| author | Greg Kroah-Hartman <gregkh@suse.de> | 2009-10-26 16:56:47 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-10-26 16:56:47 -0700 |
| commit | d93ada0e086cc8b5de957b5dfaeb1247489f1717 (patch) | |
| tree | 8cf9190742b3f65908582f829ec69e94be4fb77c /usb.current | |
| parent | 8900d1017b45890db769237176dec16a05e2fc8b (diff) | |
| download | patches-d93ada0e086cc8b5de957b5dfaeb1247489f1717.tar.gz | |
lots more staging and other patches
Diffstat (limited to 'usb.current')
| -rw-r--r-- | usb.current/usb-rndis_host-debug-info-clobbered-before-it-is-logged.patch | 42 |
1 files changed, 42 insertions, 0 deletions
diff --git a/usb.current/usb-rndis_host-debug-info-clobbered-before-it-is-logged.patch b/usb.current/usb-rndis_host-debug-info-clobbered-before-it-is-logged.patch new file mode 100644 index 00000000000000..18177e4643704c --- /dev/null +++ b/usb.current/usb-rndis_host-debug-info-clobbered-before-it-is-logged.patch @@ -0,0 +1,42 @@ +From george.nassar@gmail.com Mon Oct 26 16:33:31 2009 +From: George Nassar <george.nassar@gmail.com> +Date: Wed, 14 Oct 2009 18:27:41 -0500 +Subject: USB: rndis_host: debug info clobbered before it is logged +To: linux-usb@vger.kernel.org, gregkh@suse.de +Cc: george.nassar@gmail.com +Message-ID: <4AD65E6D.3070900@gmail.com> + + +The MTU throttle-down if a RNDIS device doesn't support a particular +packet size is being incorrectly logged. The attempted packet size is +being clobbered before it gets logged. + +First patch; please inform if I'm doing this incorrectly. Diff'd +against latest official source as per the FAQ; forward port to current +git version is straightforward. + +Signed-off-by: George Nassar <george.nassar@gmail.com> +Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> + +--- + drivers/net/usb/rndis_host.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +--- a/drivers/net/usb/rndis_host.c ++++ b/drivers/net/usb/rndis_host.c +@@ -362,12 +362,12 @@ generic_rndis_bind(struct usbnet *dev, s + retval = -EINVAL; + goto halt_fail_and_release; + } +- dev->hard_mtu = tmp; +- net->mtu = dev->hard_mtu - net->hard_header_len; + dev_warn(&intf->dev, + "dev can't take %u byte packets (max %u), " + "adjusting MTU to %u\n", +- dev->hard_mtu, tmp, net->mtu); ++ dev->hard_mtu, tmp, tmp - net->hard_header_len); ++ dev->hard_mtu = tmp; ++ net->mtu = dev->hard_mtu - net->hard_header_len; + } + + /* REVISIT: peripheral "alignment" request is ignored ... */ |