aboutsummaryrefslogtreecommitdiffstats
path: root/usb
diff options
authorGreg Kroah-Hartman <gregkh@suse.de>2009-06-15 13:16:03 -0700
committerGreg Kroah-Hartman <gregkh@suse.de>2009-06-15 13:16:03 -0700
commitb72c316ac81051a3d00d355f421b5e34339c20b2 (patch)
treede384a4bcb530db3f23072434d7a7c0a7b6ff8aa /usb
parenta40f36137a30dc17b00c73bad543b90915bf24b7 (diff)
downloadpatches-b72c316ac81051a3d00d355f421b5e34339c20b2.tar.gz
usbtmc driver fix
Diffstat (limited to 'usb')
-rw-r--r--usb/usb-usbtmc-fix-switch-statment.patch49
1 files changed, 49 insertions, 0 deletions
diff --git a/usb/usb-usbtmc-fix-switch-statment.patch b/usb/usb-usbtmc-fix-switch-statment.patch
new file mode 100644
index 00000000000000..ff612bfeb85fd5
--- /dev/null
+++ b/usb/usb-usbtmc-fix-switch-statment.patch
@@ -0,0 +1,49 @@
+From foo@baz Mon Jun 15 13:13:05 PDT 2009
+Date: Mon, 15 Jun 2009 13:13:05 -0700
+To: Greg KH <greg@kroah.com>
+From: Greg Kroah-Hartman <gregkh@suse.de>
+Subject: USB: usbtmc: fix switch statment
+
+Steve Holland pointed out that we forgot to call break; in the switch
+statment. This probably resolves a lot of the bug reports I've gotten
+for the driver lately.
+
+Stupid me...
+
+Reported-by: Steve Holland <sdh4@iastate.edu>
+Cc: stable <stable@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
+---
+ drivers/usb/class/usbtmc.c | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+--- a/drivers/usb/class/usbtmc.c
++++ b/drivers/usb/class/usbtmc.c
+@@ -927,21 +927,27 @@ static long usbtmc_ioctl(struct file *fi
+ switch (cmd) {
+ case USBTMC_IOCTL_CLEAR_OUT_HALT:
+ retval = usbtmc_ioctl_clear_out_halt(data);
++ break;
+
+ case USBTMC_IOCTL_CLEAR_IN_HALT:
+ retval = usbtmc_ioctl_clear_in_halt(data);
++ break;
+
+ case USBTMC_IOCTL_INDICATOR_PULSE:
+ retval = usbtmc_ioctl_indicator_pulse(data);
++ break;
+
+ case USBTMC_IOCTL_CLEAR:
+ retval = usbtmc_ioctl_clear(data);
++ break;
+
+ case USBTMC_IOCTL_ABORT_BULK_OUT:
+ retval = usbtmc_ioctl_abort_bulk_out(data);
++ break;
+
+ case USBTMC_IOCTL_ABORT_BULK_IN:
+ retval = usbtmc_ioctl_abort_bulk_in(data);
++ break;
+ }
+
+ mutex_unlock(&data->io_mutex);