aboutsummaryrefslogtreecommitdiffstats
path: root/0025-ehci-dbg.c-move-assignment-out-of-if-block.patch
diff options
Diffstat (limited to '0025-ehci-dbg.c-move-assignment-out-of-if-block.patch')
-rw-r--r--0025-ehci-dbg.c-move-assignment-out-of-if-block.patch33
1 files changed, 33 insertions, 0 deletions
diff --git a/0025-ehci-dbg.c-move-assignment-out-of-if-block.patch b/0025-ehci-dbg.c-move-assignment-out-of-if-block.patch
new file mode 100644
index 00000000000000..20c14efbffb4d2
--- /dev/null
+++ b/0025-ehci-dbg.c-move-assignment-out-of-if-block.patch
@@ -0,0 +1,33 @@
+From 3737858648328276d4894d33d70adf81d4d8347d Mon Sep 17 00:00:00 2001
+From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+Date: Wed, 29 Apr 2015 16:22:25 +0200
+Subject: [PATCH 25/36] ehci-dbg.c: move assignment out of if () block
+
+We should not be doing assignments within an if () block
+so fix up the code to not do this.
+
+change was created using Coccinelle.
+
+CC: Alan Stern <stern@rowland.harvard.edu>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/usb/host/ehci-dbg.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
+index 524cbf26d992..b26b96e25a13 100644
+--- a/drivers/usb/host/ehci-dbg.c
++++ b/drivers/usb/host/ehci-dbg.c
+@@ -628,7 +628,8 @@ static ssize_t fill_periodic_buffer(struct debug_buffer *buf)
+ unsigned i;
+ __hc32 tag;
+
+- if (!(seen = kmalloc (DBG_SCHED_LIMIT * sizeof *seen, GFP_ATOMIC)))
++ seen = kmalloc(DBG_SCHED_LIMIT * sizeof *seen, GFP_ATOMIC);
++ if (!seen)
+ return 0;
+ seen_count = 0;
+
+--
+2.3.7
+