diff options
Diffstat (limited to 'p10')
| -rw-r--r-- | p10 | 83 |
1 files changed, 83 insertions, 0 deletions
diff --git a/p10 b/p10 new file mode 100644 index 00000000000000..f6ced8bc890755 --- /dev/null +++ b/p10 @@ -0,0 +1,83 @@ +From e82f2d8eab210dc7eb0dba2bd8e3c64ad485442b Mon Sep 17 00:00:00 2001 +From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> +Date: Wed, 30 May 2018 16:15:35 +0200 +Subject: [PATCH] x86: mm: no need to check return value of debugfs_create functions + +When calling debugfs functions, there is no need to ever check the +return value. The function can work or not, but the code logic should +never do something different based on this. + +Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> +--- + arch/x86/mm/debug_pagetables.c | 35 +++++++---------------------------- + 1 file changed, 7 insertions(+), 28 deletions(-) + +--- a/arch/x86/mm/debug_pagetables.c ++++ b/arch/x86/mm/debug_pagetables.c +@@ -25,8 +25,6 @@ static int ptdump_curknl_show(struct seq + DEFINE_SHOW_ATTRIBUTE(ptdump_curknl); + + #ifdef CONFIG_PAGE_TABLE_ISOLATION +-static struct dentry *pe_curusr; +- + static int ptdump_curusr_show(struct seq_file *m, void *v) + { + if (current->mm->pgd) { +@@ -41,8 +39,6 @@ DEFINE_SHOW_ATTRIBUTE(ptdump_curusr); + #endif + + #if defined(CONFIG_EFI) && defined(CONFIG_X86_64) +-static struct dentry *pe_efi; +- + static int ptdump_efi_show(struct seq_file *m, void *v) + { + if (efi_mm.pgd) +@@ -53,41 +49,24 @@ static int ptdump_efi_show(struct seq_fi + DEFINE_SHOW_ATTRIBUTE(ptdump_efi); + #endif + +-static struct dentry *dir, *pe_knl, *pe_curknl; ++static struct dentry *dir; + + static int __init pt_dump_debug_init(void) + { + dir = debugfs_create_dir("page_tables", NULL); +- if (!dir) +- return -ENOMEM; + +- pe_knl = debugfs_create_file("kernel", 0400, dir, NULL, +- &ptdump_fops); +- if (!pe_knl) +- goto err; +- +- pe_curknl = debugfs_create_file("current_kernel", 0400, +- dir, NULL, &ptdump_curknl_fops); +- if (!pe_curknl) +- goto err; ++ debugfs_create_file("kernel", 0400, dir, NULL, &ptdump_fops); ++ debugfs_create_file("current_kernel", 0400, dir, NULL, ++ &ptdump_curknl_fops); + + #ifdef CONFIG_PAGE_TABLE_ISOLATION +- pe_curusr = debugfs_create_file("current_user", 0400, +- dir, NULL, &ptdump_curusr_fops); +- if (!pe_curusr) +- goto err; ++ debugfs_create_file("current_user", 0400, dir, NULL, ++ &ptdump_curusr_fops); + #endif +- + #if defined(CONFIG_EFI) && defined(CONFIG_X86_64) +- pe_efi = debugfs_create_file("efi", 0400, dir, NULL, &ptdump_efi_fops); +- if (!pe_efi) +- goto err; ++ debugfs_create_file("efi", 0400, dir, NULL, &ptdump_efi_fops); + #endif +- + return 0; +-err: +- debugfs_remove_recursive(dir); +- return -ENOMEM; + } + + static void __exit pt_dump_debug_exit(void) |