diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2026-05-26 08:35:31 -0700 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-05-27 17:42:09 -0700 |
| commit | a8d8bef6b45bf7cc0b1f6110c5cd8d0160a9bad7 (patch) | |
| tree | 090df3464d4ada4901df9812cbbe99ceea2624a8 /net | |
| parent | c3fc9976f686f9a95baf87db9d387f218fd65394 (diff) | |
| download | linux-next-history-a8d8bef6b45bf7cc0b1f6110c5cd8d0160a9bad7.tar.gz | |
ethtool: strset: fix header attribute index in ethnl_req_get_phydev()
strset_prepare_data() passes ETHTOOL_A_HEADER_FLAGS (3) as the header
attribute to ethnl_req_get_phydev(). This is incorrect, in the main
attr space 3 is ETHTOOL_A_STRSET_COUNTS_ONLY, not the request
header attr. The correct constant is ETHTOOL_A_STRSET_HEADER (1).
ethnl_req_get_phydev() only uses this value for the extack,
so this is not a "functionally visible"(?) bug.
Fixes: e96c93aa4be9 ("net: ethtool: strset: Allow querying phy stats by index")
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Link: https://patch.msgid.link/20260526153533.2779187-9-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ethtool/strset.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ethtool/strset.c b/net/ethtool/strset.c index bb1e829ba099b..94c4718d31ae0 100644 --- a/net/ethtool/strset.c +++ b/net/ethtool/strset.c @@ -311,7 +311,7 @@ static int strset_prepare_data(const struct ethnl_req_info *req_base, return 0; } - phydev = ethnl_req_get_phydev(req_base, tb, ETHTOOL_A_HEADER_FLAGS, + phydev = ethnl_req_get_phydev(req_base, tb, ETHTOOL_A_STRSET_HEADER, info->extack); /* phydev can be NULL, check for errors only */ |