Skip to content

Conversation

@LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Apr 14, 2025

Feature Preview

  • added the appflowy cloud mode icon
  • update i18n
  • replace text color in the login page

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 14, 2025

Reviewer's Guide by Sourcery

This pull request updates the login page icons and internationalization (i18n) text. It introduces a new FlowyLogoTitle widget for the sign-in screen, updates button text and icons, and adjusts spacing for a better UI. It also updates the personal info settings group title and removes third party login option from the user session settings group.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the sign-in screen UI to use a new FlowyLogoTitle widget and adjusted spacing.
  • Replaced the logo and app name widgets with the FlowyLogoTitle widget.
  • Adjusted vertical spacing between elements using theme.spacing.
  • Removed the Spacer widgets and adjusted the layout to better utilize the available space.
frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/mobile_sign_in_screen.dart
Updated the personal info settings group title.
  • Changed the group title from settings_mobile_personalInfo to settings_accountPage_title.
frontend/appflowy_flutter/lib/mobile/presentation/setting/personal_info/personal_info_setting_group.dart
Updated the sign-in agreement text.
  • Removed conditional logic for local authentication agreement text.
  • Updated the agreement text to use the generic web_signInAgreement translation key.
frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/widgets/sign_in_agreement.dart
Updated the cloud mode button text and icon.
  • Updated the button text to use the signIn_switchToAppFlowyCloud translation key.
  • Updated the icon to use the cloud_mode_m SVG.
frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/widgets/sign_in_anonymous_button.dart
Updated the anonymous sign-in button text.
  • Updated the button text to use the signIn_continueWithLocalModel translation key.
frontend/appflowy_flutter/lib/user/presentation/screens/sign_in_screen/widgets/anonymous_sign_in_button.dart
Removed third party login option from the user session settings group.
  • Set showThirdPartyLogin to false.
frontend/appflowy_flutter/lib/mobile/presentation/home/mobile_home_setting_page.dart
Added new SVG icon for cloud mode.
  • Added cloud_mode.svg to the flowy_icons directory.
Added new SVG icon for sign in settings.
  • Added sign_in_settings.svg to the flowy_icons directory.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions
Copy link

github-actions bot commented Apr 14, 2025

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Message without source 1 warning contribute (via Fink 🐦)
Missing translation 58 warning contribute (via Fink 🐦)
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LucasXu0 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a consistent naming scheme for your widgets, e.g., prefixing all widget names with _build.
  • The removal of colorScheme and introduction of theme is good, but ensure all color usages are now theme-aware.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@LucasXu0 LucasXu0 merged commit 1630e11 into AppFlowy-IO:main Apr 15, 2025
18 checks passed
LucasXu0 added a commit to LucasXu0/AppFlowy that referenced this pull request Apr 15, 2025
* feat: update i18n and icons

* chore: replace appflowy with welcome to appflowy

* fix: protenial delete page error

* fix: flutter analyze
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant