-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
chore: update login page icons and i18n #7742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request updates the login page icons and internationalization (i18n) text. It introduces a new No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
🥷 Ninja i18n – 🛎️ Translations need to be updatedProject
|
| lint rule | new reports | level | link |
|---|---|---|---|
| Message without source | 1 | warning | contribute (via Fink 🐦) |
| Missing translation | 58 | warning | contribute (via Fink 🐦) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LucasXu0 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a consistent naming scheme for your widgets, e.g., prefixing all widget names with
_build. - The removal of
colorSchemeand introduction ofthemeis good, but ensure all color usages are now theme-aware.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
14753fb to
57672cd
Compare
c548b31 to
e6be173
Compare
* feat: update i18n and icons * chore: replace appflowy with welcome to appflowy * fix: protenial delete page error * fix: flutter analyze
Feature Preview
PR Checklist